Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SQLAlchemy 2.0 support #115

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

coetzeevs
Copy link

@coetzeevs coetzeevs commented Feb 9, 2025

What

Adding changes to support SQLAlchemy 2.0.

Changes

  • update dependencies and resolve some conflicts that caused issues when running updates. Specifically, a circular dependency issue arose related to fs-s3fs and boto3 and urllib3. The solve was to pin the version for urllib3.
  • resolve some issues with the docker-compose file by pinning the mysql version to 8.0 (newer versions have default-authentication-plugin as deprecated and this maintains the current intended behaviour). Also set the ssh key path in the ssh server as read-write and fix the port config which was causing issues at test runtime (no connection)
  • change the mode of the ssh_host_rwsa_key file using chmod 600 to resolve issues with auth at test runtime
  • change test files and client to support sqlalchemy 2.0
  • update test-replication-key to use _singerlib.catalog per the TODO notes
  • update test-ssh-tunnel to use the ssh key file content i.s.o. hardcoding it
  • update ssh connection parameter to drop deprecated field and use ssh_pkey instead.
  • use specific commit approach to make sure test data is created on the stream

Note

My last two commits are unverified - I tried to resolve this but something bugged out on my machine. Need to figure it out. Can deal with it if it's a must to have verified and signed commits.

@coetzeevs coetzeevs changed the title [FEAT] - SQLAlchemy 2.0 support feat: SQLAlchemy 2.0 support Feb 9, 2025
@coetzeevs coetzeevs force-pushed the feature/support-sqlalchemy-2.0 branch from b760903 to a206d4e Compare February 9, 2025 20:28
@edgarrmondragon
Copy link
Member

My last two commits are unverified - I tried to resolve this but something bugged out on my machine. Need to figure it out. Can deal with it if it's a must to have verified and signed commits.

No need to worry about that.

@coetzeevs coetzeevs marked this pull request as ready for review February 15, 2025 16:39
@coetzeevs
Copy link
Author

@edgarrmondragon I've resolved the last test cases. I saw the CI tests failing to connect during ssh tests, not sure what the cause is yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants