-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: SQLAlchemy 2.0 support #115
Open
coetzeevs
wants to merge
13
commits into
MeltanoLabs:main
Choose a base branch
from
coetzeevs:feature/support-sqlalchemy-2.0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: SQLAlchemy 2.0 support #115
coetzeevs
wants to merge
13
commits into
MeltanoLabs:main
from
coetzeevs:feature/support-sqlalchemy-2.0
+343
−250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… before tests exit
b760903
to
a206d4e
Compare
a206d4e
to
970d0bf
Compare
No need to worry about that. |
@edgarrmondragon I've resolved the last test cases. I saw the CI tests failing to connect during ssh tests, not sure what the cause is yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adding changes to support SQLAlchemy 2.0.
Changes
default-authentication-plugin
as deprecated and this maintains the current intended behaviour). Also set the ssh key path in the ssh server as read-write and fix the port config which was causing issues at test runtime (no connection)chmod 600
to resolve issues with auth at test runtimeNote
My last two commits are unverified - I tried to resolve this but something bugged out on my machine. Need to figure it out. Can deal with it if it's a must to have verified and signed commits.