Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: planet scale working #45

Merged
merged 26 commits into from
Feb 23, 2024
Merged
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
a08e4b3
WIP Discovery working, need to get tables working, and then refactor
visch Feb 16, 2024
7359da5
Working with access issues fitlered out
visch Feb 17, 2024
248be32
Works with 100k+ tables
visch Feb 17, 2024
1b155d9
Fix decimals
visch Feb 17, 2024
49f125a
Dynamic PlanetScale detection
visch Feb 17, 2024
a1a0580
Readme updated, planet scale working
visch Feb 17, 2024
f06bffd
Swap config name for sqlalchemy options
visch Feb 19, 2024
6c90cfb
Add is_vitess configuration
visch Feb 20, 2024
685a2e9
Merge main's poetry.lock file in
visch Feb 20, 2024
84fc4b3
Make linter happy
visch Feb 21, 2024
8c2d124
Fix config validation, and messup with connect function call
visch Feb 21, 2024
8809b65
Passes all tests, squashed some bugs!
visch Feb 21, 2024
7644319
make mypy happy
visch Feb 21, 2024
0b07d39
PlanetScale tap pointer
visch Feb 21, 2024
c84d384
fix merge conflicts
visch Feb 22, 2024
f7520c9
Fix sqlalchemy_options documentation
visch Feb 22, 2024
6c0e974
Fix vitess config check
visch Feb 22, 2024
fa8ac91
Update README.md
visch Feb 22, 2024
7e2a11b
Update README.md
visch Feb 22, 2024
3ac1ceb
Apply Edgars suggestions
visch Feb 22, 2024
d986bba
Merge branch 'planet_scale' of github.com:MeltanoLabs/tap-mysql into …
visch Feb 22, 2024
164b94f
Match tap.py config docs with README
visch Feb 22, 2024
6c40462
A bit cleaner is_vitess check
visch Feb 22, 2024
1b34310
config key doesn't get set when value is None. I didn't expect that!
visch Feb 22, 2024
563e229
Merge branch 'main' into planet_scale
edgarrmondragon Feb 23, 2024
76b0b11
Merge branch 'main' into planet_scale
visch Feb 23, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Match tap.py config docs with README
visch committed Feb 22, 2024
commit 164b94f3e11d4d0507be565c0b9cd80b5bd68b80
2 changes: 1 addition & 1 deletion tap_mysql/tap.py
Original file line number Diff line number Diff line change
@@ -126,7 +126,7 @@ def __init__(
th.BooleanType,
default=None,
description=(
"By default we'll check if the database is a Vitess instance, "
"By default we'll check if the database is a Vitess instance. "
"If you would rather not automatically check, set this to "
"`False`. See Vitess/PlanetScale documentation below for more "
"information."