Skip to content

Commit

Permalink
fix: Work around unsupported json_serializer and json_deserializer (
Browse files Browse the repository at this point in the history
  • Loading branch information
edgarrmondragon authored Aug 9, 2023
1 parent 6047709 commit c1cbb8c
Showing 1 changed file with 6 additions and 7 deletions.
13 changes: 6 additions & 7 deletions tap_snowflake/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,17 +68,16 @@ def get_sqlalchemy_url(cls, config: dict) -> str:

return URL(**params)

def create_sqlalchemy_engine(self) -> sqlalchemy.engine.Engine:
"""Return a new SQLAlchemy engine using the provided config.
Developers can generally override just one of the following:
`sqlalchemy_engine`, sqlalchemy_url`.
def create_engine(self) -> sqlalchemy.engine.Engine:
"""Create SQLAlchemy engine instance.
Returns:
A newly created SQLAlchemy engine object.
A SQLAlchemy engine.
"""
return sqlalchemy.create_engine(
self.sqlalchemy_url, echo=False, pool_timeout=10
self.sqlalchemy_url,
echo=False,
pool_timeout=10,
)

# overridden to filter out the information_schema from catalog discovery
Expand Down

0 comments on commit c1cbb8c

Please sign in to comment.