Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

working mvp #2

Merged
merged 33 commits into from
Oct 27, 2022
Merged

working mvp #2

merged 33 commits into from
Oct 27, 2022

Conversation

kgpayne
Copy link
Collaborator

@kgpayne kgpayne commented Sep 14, 2022

@kgpayne
Copy link
Collaborator Author

kgpayne commented Sep 16, 2022

OK, this is getting close 😅 I have stream property selection working for both RECORD and BATCH and also STATE working for RECORD. State and batch need to be worked on a bit. Right now INCREMENTAL is not supported with the BATCH message type (issue sdk#976) in the SDK, as we don't initialise any existing replication keys on that code path, nor do we provide a mechanism for users to report the bookmark associated with their batch 🤔

@kgpayne kgpayne marked this pull request as ready for review September 26, 2022 11:27
@kgpayne
Copy link
Collaborator Author

kgpayne commented Sep 26, 2022

@pnadolny13 once this merges, it would be good to start using it in squared 😅 Also, do we have a sanitised Snowflake user/database/warehouse that we can use for testing? I have been using internal creds for development, but it would be good to create some tests that utilise an example Snowflake instance that is 'safe' to be used in the MeltanoLabs context. A read-only user with access to example data should be more than sufficient 🙂

@pnadolny13
Copy link
Contributor

@pnadolny13 once this merges, it would be good to start using it in squared 😅

@kgpayne sounds good I created meltano/squared#425 to track migrating to this variant.

Also, do we have a sanitised Snowflake user/database/warehouse that we can use for testing? I have been using internal creds for development, but it would be good to create some tests that utilise an example Snowflake instance that is 'safe' to be used in the MeltanoLabs context. A read-only user with access to example data should be more than sufficient 🙂

We have sample data but we dont have a read only user for that right now but I can create one. I created an issue for tracking it.

Copy link
Collaborator Author

@kgpayne kgpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of questions for feedback 🙂

tap_snowflake/client.py Show resolved Hide resolved
tap_snowflake/client.py Outdated Show resolved Hide resolved
Copy link
Member

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kgpayne kgpayne merged commit 5d7aef2 into main Oct 27, 2022
@kgpayne kgpayne deleted the working-mvp branch October 27, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: native Snowflake bulk unload for BATCH messages
4 participants