feat: support Vite 5 #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Menci Can this be merged? FYI: legacy browser tests fail on my machine as well |
|
Thanks. I'll check it soon. |
|
I propose we have a new major release and drop Vite 2/3. And Node 14/16. |
|
@aljazerzen @wyatt-herkamp Now everything should just work. Please check it and after then I'll merge and release it. For the broken test, it's because the upgrade of |
|
Tested against my website it worked fine. Test Suite passed too. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not working on Legacy Browsers the tests for Legacy browser is failing. If you know how to fix this please help.
I did updated the other dependencies.
@babel/preset-envwanted a peer dependency of@babel/core