New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve CJS Interoperability #50

Merged

Menci merged 1 commit into Menci:main from magic-akari:fix/glue-code

Jan 20, 2024

Contributor

magic-akari commented Jan 20, 2024

No description provided.


          fix: improve CJS Interoperability

124368f

Contributor Author

magic-akari commented Jan 20, 2024 •

edited

Loading

This pull request resolves two issues:

Improves interoperability with CommonJS by utilizing the import namespace syntax.
Avoid creating invalid import name bindings.

In JavaScript, not all export names can be used as valid variable names. For example:

const a = 42;

export { a as "🥰" };

Menci merged commit a79f392 into Menci:main

4 checks passed

zuckschwerdt mentioned this pull request

fetch wasm file should append baseUrl base on currenScript running env #47

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet