DRAFT: qemu-system-native: fix mouse co-ordinates scaling issue #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in continuation of commit 59cc33d. The previous commit solved the issue with SDL,GL but since scaling issue was only related to opengl, the scaling shouldn't have been applied otherwise. So, conditionally scale the mouse co-ordinates only for SDL,GL. Moreover, moved the logic to common place and now the scaling isn't actually required, if we just choose the correct surface dimension based on opengl context. JIRA-ID: SB-23711 Signed-off-by: Haseeb Ashraf <[email protected]>
hashraf91
requested review from
kergoth,
Noor-Ahsan,
ahsanhussain and
hijaz-siemens
|
@kergoth I checked with qemu-9.0.2 in oe-core:master-next and this issue is still there. Although, I have yet to check in QEMU master. @Noor-Ahsan we'll have to submit this updated patch to qemu-s2s repository as well. |
hashraf91
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in continuation of commit 59cc33d.
The previous commit solved the issue with SDL,GL but since scaling issue was only related to opengl, the scaling shouldn't have been applied otherwise. So, conditionally scale the mouse co-ordinates only for SDL,GL.
Moreover, moved the logic to common place and now the scaling isn't actually required, if we just choose the correct surface dimension based on opengl context.
JIRA-ID: SB-23711