Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed Up Preloading #69

Merged
merged 3 commits into from
Sep 7, 2023
Merged

Speed Up Preloading #69

merged 3 commits into from
Sep 7, 2023

Conversation

FoxMoss
Copy link
Contributor

@FoxMoss FoxMoss commented Sep 7, 2023

Tiny patch, it just loads preloads file async now.

@velzie
Copy link
Member

velzie commented Sep 7, 2023

have you tested it?

@ProgrammerIn-wonderland
Copy link
Collaborator

iirc the reason I didn't have it be async is that it literally crashed and overloaded the filesystem cache

@FoxMoss
Copy link
Contributor Author

FoxMoss commented Sep 7, 2023 •
edited
Loading

yes i did

@FoxMoss
Copy link
Contributor Author

FoxMoss commented Sep 7, 2023

it literally worked fine

@FoxMoss
Copy link
Contributor Author

FoxMoss commented Sep 7, 2023

i can chunk it if that works better on lower end devices

@Endercass
Copy link
Member

yes i did

What browser and version?

Did you fully clear site data?

@velzie
Copy link
Member

velzie commented Sep 7, 2023

breaks parts of the cache for me
try chunking it in batches of 10 maybe

@ProgrammerIn-wonderland
Copy link
Collaborator

half works for me, temporarily degraded filesystem but after like 20s it started working normally, I'm on a Samsung 980 nonpro NVME ssd, and i7-8700 with 48GB ram

@velzie
Copy link
Member

velzie commented Sep 7, 2023

to be more specific, it's dropping files, if you look at the netlog some don't load properly when offline

@FoxMoss
Copy link
Contributor Author

FoxMoss commented Sep 7, 2023 •
edited
Loading

What browser and version?

Chromium Version 114.0.5735.198 (Official Build) for Linux Mint (64-bit)

Did you fully clear site data?

I cleared the cache via this menu in chrome
image

@ProgrammerIn-wonderland
Copy link
Collaborator

yup thats usually what I do too

@ProgrammerIn-wonderland
Copy link
Collaborator

I have a feeling this issue is heavily dependent on system performance, since it relies on how fast it can store the files into the filesystem

@Endercass
Copy link
Member

What browser and version?

Chromium Version 114.0.5735.198 (Official Build) for Linux Mint (64-bit)

Did you fully clear site data?

I cleared the cache via this menu in chrome
image

yeah your parameters seem fine, are you sure none of the files dropped?

@ProgrammerIn-wonderland
Copy link
Collaborator

but the filesystem is definitely still being overloaded here, even on my machine and I suspect on CE's its passing the limit on how many files could have been overloaded

@ProgrammerIn-wonderland
Copy link
Collaborator

does anyone here have a Google Octopus board chromebook to test on?

@FoxMoss
Copy link
Contributor Author

FoxMoss commented Sep 7, 2023 •
edited
Loading

yeah your parameters seem fine, are you sure none of the files dropped?

i will check, im also implementing chunking rn

@ProgrammerIn-wonderland
Copy link
Collaborator

@FoxMoss, system specifications?

@Endercass
Copy link
Member

does anyone here have a Google Octopus board chromebook to test on?

i do have a octopus chromebook but i also do not have time until tomorrow.

@FoxMoss
Copy link
Contributor Author

FoxMoss commented Sep 7, 2023 •
edited
Loading

@FoxMoss, system specifications?

H/W path           Device           Class          Description
==============================================================
                                    system         HP ProBook 645 G2 (L8X67AV)
/0                                  bus            80FE
/0/3                                memory         64KiB BIOS
/0/2                                processor      AMD PRO A8-8600B R6, 10 Compute Cores 4C+6G
/0/2/0                              memory         320KiB L1 cache
/0/2/1                              memory         2MiB L2 cache
/0/13                               memory         8GiB System Memory
/0/13/0                             memory         8GiB SODIMM DDR3 Synchronous Unbuffered (Unregistered) 1600 MHz (0.6 ns)
/0/13/1                             memory         DDR3 [empty]
/0/100                              bridge         Family 15h (Models 60h-6fh) Processor Root Complex
/0/100/0.2                          generic        Family 15h (Models 60h-6fh) I/O Memory Management Unit
/0/100/1           /dev/fb0         display        Wani [Radeon R5/R6/R7 Graphics]
/0/100/1.1         card0            multimedia     Kabini HDMI/DP Audio
/0/100/1.1/0       input17          input          HDA ATI HDMI HDMI/DP,pcm=3
/0/100/1.1/1       input18          input          HDA ATI HDMI HDMI/DP,pcm=7
/0/100/1.1/2       input19          input          HDA ATI HDMI HDMI/DP,pcm=8
/0/100/2.1                          bridge         Family 15h (Models 60h-6fh) Processor Root Port
/0/100/2.1/0       enp1s0           network        RTL8111/8168/8411 PCI Express Gigabit Ethernet Controller
/0/100/2.3                          bridge         Family 15h (Models 60h-6fh) Processor Root Port
/0/100/2.3/0                        network        Wireless 7265
/0/100/2.5                          bridge         Family 15h (Models 60h-6fh) Processor Root Port
/0/100/2.5/0       mmc0             bus            RTS522A PCI Express Card Reader
/0/100/8                            generic        Carrizo Platform Security Processor
/0/100/9.2         card1            multimedia     Family 15h (Models 60h-6fh) Audio Controller
/0/100/9.2/0       input20          input          HD-Audio Generic Mic
/0/100/9.2/1       input21          input          HD-Audio Generic Headphone
/0/100/10                           bus            FCH USB XHCI Controller
/0/100/10/0        usb2             bus            xHCI Host Controller
/0/100/10/0/4                       generic        802.11n NIC
/0/100/10/1        usb3             bus            xHCI Host Controller
/0/100/11          scsi0            storage        FCH SATA Controller [AHCI mode]
/0/100/11/0.0.0    /dev/sda         disk           128GB SanDisk SD8SN8U-
/0/100/11/0.0.0/1  /dev/sda1        volume         511MiB Windows FAT volume
/0/100/11/0.0.0/2  /dev/sda2        volume         118GiB EXT4 volume
/0/100/12                           bus            FCH USB EHCI Controller
/0/100/12/1        usb1             bus            EHCI Host Controller
/0/100/12/1/1                       bus            Root Hub
/0/100/12/1/1/3                     bus            USB2.0 Hub
/0/100/12/1/1/3/2                   communication  Bluetooth wireless interface
/0/100/14                           bus            FCH SMBus Controller
/0/100/14.3                         bridge         FCH LPC Bridge
/0/100/14.3/0                       system         PnP device PNP0b00
/0/100/14.3/1                       system         PnP device PNP0c02
/0/100/14.3/2                       system         PnP device PNP0c01
/0/100/14.3/3                       generic        PnP device HPQ8002
/0/100/14.3/4                       generic        PnP device SYN3032
/0/100/14.3/5                       system         PnP device PNP0c02
/0/100/14.3/6                       system         PnP device PNP0c02
/0/100/14.3/7                       generic        PnP device IFX0102
/0/101                              bridge         Family 15h (Models 60h-6fh) Host Bridge
/0/102                              bridge         Family 15h (Models 60h-6fh) Host Bridge
/0/103                              bridge         Carrizo Audio Dummy Host Bridge
/0/104                              bridge         Family 15h (Models 60h-6fh) Processor Function 0
/0/105                              bridge         Family 15h (Models 60h-6fh) Processor Function 1
/0/106                              bridge         Family 15h (Models 60h-6fh) Processor Function 2
/0/107                              bridge         Family 15h (Models 60h-6fh) Processor Function 3
/0/108                              bridge         Family 15h (Models 60h-6fh) Processor Function 4
/0/109                              bridge         Family 15h (Models 60h-6fh) Processor Function 5
/1                                  power          CI03048XL
/2                 input0           input          Power Button
/3                 input1           input          Sleep Button
/4                 input11          input          PS/2 Generic Mouse
/5                 input12          input          SynPS/2 Synaptics TouchPad
/6                 input14          input          Wireless hotkeys
/7                 input15          input          ST LIS3LV02DL Accelerometer
/8                 input16          input          HP WMI hotkeys
/9                 input2           input          Lid Switch
/a                 input3           input          Power Button
/b                 input4           input          AT Translated Set 2 keyboard
/c                 input9           input          Video Bus
/d                 wlx14ebb67f22ac  network        Wireless interface

I also have hardware acceleration turned off on chrome

@FoxMoss
Copy link
Contributor Author

FoxMoss commented Sep 7, 2023

Fuckin git

@FoxMoss
Copy link
Contributor Author

FoxMoss commented Sep 7, 2023

Added chunking though 👍

@velzie
Copy link
Member

velzie commented Sep 7, 2023

image
erm. buddy

@FoxMoss
Copy link
Contributor Author

FoxMoss commented Sep 7, 2023

yeah i know

@FoxMoss
Copy link
Contributor Author

FoxMoss commented Sep 7, 2023 •
edited
Loading

i literally signed all the commits idk what its on about, i might need to make a new pr

@builtbyvys
Copy link
Member

you added your PGP key on github and added your signing key to git?

@velzie
Copy link
Member

velzie commented Sep 7, 2023

yeah it doesn't say [verified] next to your commits so i don't think you added it

@ProgrammerIn-wonderland
Copy link
Collaborator

@CoolElectronics test?

@velzie
Copy link
Member

velzie commented Sep 7, 2023

things are still broken, just not because of this commit

@velzie velzie merged commit 8976582 into MercuryWorkshop:main Sep 7, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@FoxMoss @velzie @ProgrammerIn-wonderland @Endercass @builtbyvys