Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve how we detect that the PR is managed by Mergify #37

Conversation

DouglasBlackwood
Copy link
Contributor

The previous fix doesn't work on the old GitHub UI because the check-runs aren't built the same way. This PR adds a new way to find Mergify's icon on the page.

Fixes MRGFY-4595

The previous fix doesn't work on the old GitHub UI because the check-runs aren't built the same way. This PR adds a new way to find Mergify's icon on the page.

Fixes MRGFY-4595

Change-Id: I6b2ee9af80034951559d935af85704df70972931
@mergify mergify bot requested a review from a team January 21, 2025 09:46
Copy link
Contributor

mergify bot commented Jan 21, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Changelog requirements

Wonderful, this rule succeeded.
  • any of:
    • -title ~= ^feat
    • label = need changelog
    • label = skip changelog

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🟢 🔎 Reviews

Wonderful, this rule succeeded.
  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

@mergify mergify bot merged commit 2fe3c1d into main Jan 21, 2025
6 checks passed
@mergify mergify bot deleted the devs/DouglasBlackwood/fix-pydantic/I6b2ee9af80034951559d935af85704df70972931 branch January 21, 2025 09:48
@mergify mergify bot added queued and removed queued labels Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants