Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rewrite the action in python #16

Conversation

sileht
Copy link
Member

@sileht sileht commented Nov 8, 2024

This will avoid some bugs we have with bash escaping.

Copy link
Contributor

mergify bot commented Nov 8, 2024

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Changelog requirements

Wonderful, this rule succeeded.
  • any of:
    • -title ~= ^feat
    • label = need changelog
    • label = skip changelog

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🟢 🔎 Reviews

Wonderful, this rule succeeded.
  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

@mergify mergify bot requested a review from a team November 8, 2024 17:40
lecrepont01
lecrepont01 previously approved these changes Nov 12, 2024
This will avoid some bugs we have with bash escaping.

Change-Id: I51e3434e4710d4b72b832a17090a0e7a0bdce70c
@sileht sileht force-pushed the devs/sileht/better-match/I51e3434e4710d4b72b832a17090a0e7a0bdce70c branch from 6a87ad3 to 577e54d Compare November 19, 2024 09:01
@mergify mergify bot dismissed lecrepont01’s stale review November 19, 2024 09:01

Pull request has been modified.

@mergify mergify bot requested a review from a team November 19, 2024 09:02
@sileht
Copy link
Member Author

sileht commented Nov 19, 2024

@Mergifyio refresh

Copy link
Contributor

mergify bot commented Nov 19, 2024

refresh

✅ Pull request refreshed

@sileht
Copy link
Member Author

sileht commented Nov 20, 2024

https://github.com/Mergifyio queue

Copy link
Contributor

mergify bot commented Nov 20, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 5819cfd

mergify bot added a commit that referenced this pull request Nov 20, 2024
@mergify mergify bot added the queued label Nov 20, 2024
@mergify mergify bot merged commit 5819cfd into main Nov 20, 2024
7 checks passed
@mergify mergify bot deleted the devs/sileht/better-match/I51e3434e4710d4b72b832a17090a0e7a0bdce70c branch November 20, 2024 10:23
@mergify mergify bot removed the queued label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants