Enforce valid email address for User email #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varmar05
requested changes
Oct 28, 2024
server/migrations/community/1a6175c78a10_email_address_format_check.py
Outdated
Show resolved
Hide resolved
varmar05
reviewed
Oct 28, 2024
|
I am not confident with this change and multi language support. |
varmar05
requested changes
Dec 10, 2024
| @@ -29,6 +30,11 @@ def username_validation(form, field): | |||
| ) | |||
|
|
|||
|
|
|||
| def email_format(form, field): | |||
There was a problem hiding this comment.
how about extending Email() validator?
| @@ -7,7 +7,7 @@ | |||
| from typing import List, Optional | |||
| import bcrypt | |||
| from flask import current_app, request | |||
| from sqlalchemy import or_, func | |||
| from sqlalchemy import or_, func, CheckConstraint | |||
There was a problem hiding this comment.
do we need CheckConstraint?
|
|
||
| def contains_email_invalid_characters(email: str) -> bool: | ||
| """Check for invalid characters for the email address""" | ||
| invalid_characters = r"[ ;:’\–\—|,]" |
There was a problem hiding this comment.
What about two . in username, how is this handled?
Do we have some sources about 'standard' emails validations?
| """Check if given text is in UTF-8 encoding""" | ||
| try: | ||
| text.encode("utf-8").decode("utf-8") | ||
| return "�" not in text |
|
@harminius I suggest also to check db against invalid characters and non-utf8 mess, if you can pass me the queries |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2537
contains_email_invalid_charactersfunction only adds a few invalid characters, most of the others are caught by WTForms Email validatorTherefore, introducing a DB constraint with a definite list of invalid characters does not make much sense.