Unquote secret_access_key in s3CloudSender plugin #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since we have a built in S3 transfer class now, but we're still using it.
|
This one worries me... there might be unintentional escape sequences in our existing db's and also all the secrets need to be encoded... not clear how the migration works. |
|
Is this only for s3 or for all passwords? Should we do it for all passwords? |
|
This PR is just for the s3CloudSender plugin, there's no change to the S3 transfer class or any other part of the code. It should be safe. This is the version of the code that we've been using in ops for a few months from the internal plugins repo. |
|
For all other parts of the code, we decided #989 that we'd add an option to allow the user to specify if a password is URL encoded or not. I still think that's a good approach |
petersilva
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin is kind of redundant because we have a built in S3 transfer class now, but we're still using it right so we might as well have the latest code in the repo. I don't think the transfer class handles URL encoded passwords.
In this change, I'm assuming the password is always URL encoded.
We have an issue to add an option to credentials.conf to let the user specify whether it's URL encoded or not. Right now most (all?) of the rest of the code assumes that passwords are not URL encoded.
#989