add sdnotify support to cli, for Systemd #1324
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #1318 systemd recommends against Type=forking, preferring TYPE=notify. To do that, we need to make little api calls during startup and shutdown. Added those. This makes systemd happier on startup and seems to show status messages correctly.
petersilva
requested review from
reidsunderland,
junhu3,
andreleblanc11 and
mshak2
Test Results238 tests 235 ✅ 1m 30s ⏱️ For more details on these failures, see this check. Results for commit 7c3ca6e. ♻️ This comment has been updated with latest results. |
|
This does not work... existing development branch actually works better on 22.04 and 24.04... dropping this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1318 systemd recommends against Type=forking, preferring TYPE=notify. To do that, we need to make little api calls during startup and shutdown. Added those.
This makes systemd happier on startup and seems to show status messages correctly.