Issue1297 part2 ordering mdelaylatest #1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If links are transient, they are no longer there when the link is attempted, allow a recovery by falling through to an ordinary file copy.
with an update to an ordinary file, each new content replaces the old but sometimes there is a sequence of events, where order is necessary. so dispatch the earlier event immediately, rather than discarding it.
Test Results239 tests 234 ✅ 1m 34s ⏱️ For more details on these failures, see this check. Results for commit 58eb63b. |
andreleblanc11
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another step towards addressing hard ordering constraints.
The other commit is about the 30 second queue. We delay processing of all events
by 30 seconds so that multiple file re-writes get collapsed into a single overwrite. In
the case of mixed operations "mv/ln -s" etc... operations are done on the same file,
then order is important so dispatch the earlier event immediately, rather than
discarding the intermediate event.