Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to coq/coq#18973. #1088

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Adapt to coq/coq#18973. #1088

merged 1 commit into from
Jun 14, 2024

Conversation

rlepigre
Copy link

@rlepigre rlepigre commented Jun 4, 2024

No description provided.

@rlepigre rlepigre mentioned this pull request Jun 4, 2024
4 tasks
@JasonGross
Copy link
Contributor

Surely this will require similar changes in PCUIC and quotation at least, right?

@rlepigre
Copy link
Author

rlepigre commented Jun 4, 2024

Surely this will require similar changes in PCUIC and quotation at least, right?

OK, I'll have another look, thanks. I should probably have let my local build finish. 😅

@rlepigre rlepigre force-pushed the br/prim-string branch 2 times, most recently from 31e39de to 1ba8c66 Compare June 5, 2024 14:18
@rlepigre
Copy link
Author

rlepigre commented Jun 5, 2024

Note that this might not be complete yet: I'm having performance trouble.

@rlepigre rlepigre force-pushed the br/prim-string branch 4 times, most recently from f981a63 to 38d40c4 Compare June 5, 2024 14:52
@proux01
Copy link
Contributor

proux01 commented Jun 14, 2024

Upstream merged, please merge

@proux01
Copy link
Contributor

proux01 commented Jun 14, 2024

Ping @mattam82 or @ppedrot (you have the rights IIRC)

@tabareau tabareau merged commit b4d67e4 into MetaCoq:main Jun 14, 2024
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants