Adapt to coq PR #17991 which lets "simpl" refolds partial applications of fixpoints #975
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
simpl
reduction used to not refold the partially applied recursive calls of reducible fixpoints as this was requiring eta-conversion. Thanks to eta-conversion support, this is not anymore needed and Coq PR coq/coq#17991 implements refolding of partial applications.This has an impact on metacoq, in the file
Typing.v
of template-coq, namely, the expressionreduces with the Coq PR to
while it reduced before to
S (Nat.max (typing_size H) (typing_spine_size (fun (x : global_env_ext) (x0 : context) (x1 x2 : term) (x3 : x;;; x0 |- x1 : x2) => typing_size x3) Σ Γ t_ty l t' t0
Assuming that the new behavior is "better" (more intelligible, more intuitive), this metacoq PR ensures that
Typing.v
compiles both with and without the change of behavior ofsimpl
(the change is not very smart but works).If ok for you, the PR can then be merged as soon as now.