Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use registry from network controller #1507

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Use registry from network controller #1507

wants to merge 10 commits into from

Conversation

shanejonas
Copy link
Contributor

No description provided.

@shanejonas shanejonas requested a review from a team as a code owner July 14, 2023 15:35
@shanejonas
Copy link
Contributor Author

@metamaskbot publish-preview

1 similar comment
@shanejonas
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask/address-book-controller": "3.0.0-preview.6f2de7a",
  "@metamask/announcement-controller": "4.0.0-preview.6f2de7a",
  "@metamask/approval-controller": "3.4.0-preview.6f2de7a",
  "@metamask/assets-controllers": "10.0.0-preview.6f2de7a",
  "@metamask/base-controller": "3.1.0-preview.6f2de7a",
  "@metamask/composable-controller": "3.0.0-preview.6f2de7a",
  "@metamask/controller-utils": "4.1.0-preview.6f2de7a",
  "@metamask/ens-controller": "4.0.0-preview.6f2de7a",
  "@metamask/gas-fee-controller": "6.0.1-preview.6f2de7a",
  "@metamask/keyring-controller": "6.0.0-preview.6f2de7a",
  "@metamask/logging-controller": "1.0.0-preview.6f2de7a",
  "@metamask/message-manager": "7.0.2-preview.6f2de7a",
  "@metamask/network-controller": "10.3.0-preview.6f2de7a",
  "@metamask/notification-controller": "3.0.0-preview.6f2de7a",
  "@metamask/permission-controller": "4.0.1-preview.6f2de7a",
  "@metamask/phishing-controller": "5.0.0-preview.6f2de7a",
  "@metamask/preferences-controller": "4.2.0-preview.6f2de7a",
  "@metamask/rate-limit-controller": "3.0.0-preview.6f2de7a",
  "@metamask/signature-controller": "5.2.0-preview.6f2de7a",
  "@metamask/transaction-controller": "7.0.0-preview.6f2de7a"
}

@shanejonas
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask/address-book-controller": "3.0.0-preview.ffc516f",
  "@metamask/announcement-controller": "4.0.0-preview.ffc516f",
  "@metamask/approval-controller": "3.4.0-preview.ffc516f",
  "@metamask/assets-controllers": "10.0.0-preview.ffc516f",
  "@metamask/base-controller": "3.1.0-preview.ffc516f",
  "@metamask/composable-controller": "3.0.0-preview.ffc516f",
  "@metamask/controller-utils": "4.1.0-preview.ffc516f",
  "@metamask/ens-controller": "4.0.0-preview.ffc516f",
  "@metamask/gas-fee-controller": "6.0.1-preview.ffc516f",
  "@metamask/keyring-controller": "6.0.0-preview.ffc516f",
  "@metamask/logging-controller": "1.0.0-preview.ffc516f",
  "@metamask/message-manager": "7.0.2-preview.ffc516f",
  "@metamask/network-controller": "10.3.0-preview.ffc516f",
  "@metamask/notification-controller": "3.0.0-preview.ffc516f",
  "@metamask/permission-controller": "4.0.1-preview.ffc516f",
  "@metamask/phishing-controller": "5.0.0-preview.ffc516f",
  "@metamask/preferences-controller": "4.2.0-preview.ffc516f",
  "@metamask/rate-limit-controller": "3.0.0-preview.ffc516f",
  "@metamask/signature-controller": "5.2.0-preview.ffc516f",
  "@metamask/transaction-controller": "7.0.0-preview.ffc516f"
}

@shanejonas
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask/address-book-controller": "3.0.0-preview.746bcb9",
  "@metamask/announcement-controller": "4.0.0-preview.746bcb9",
  "@metamask/approval-controller": "3.4.0-preview.746bcb9",
  "@metamask/assets-controllers": "10.0.0-preview.746bcb9",
  "@metamask/base-controller": "3.1.0-preview.746bcb9",
  "@metamask/composable-controller": "3.0.0-preview.746bcb9",
  "@metamask/controller-utils": "4.1.0-preview.746bcb9",
  "@metamask/ens-controller": "4.0.0-preview.746bcb9",
  "@metamask/gas-fee-controller": "6.0.1-preview.746bcb9",
  "@metamask/keyring-controller": "6.0.0-preview.746bcb9",
  "@metamask/logging-controller": "1.0.0-preview.746bcb9",
  "@metamask/message-manager": "7.0.2-preview.746bcb9",
  "@metamask/network-controller": "10.3.0-preview.746bcb9",
  "@metamask/notification-controller": "3.0.0-preview.746bcb9",
  "@metamask/permission-controller": "4.0.1-preview.746bcb9",
  "@metamask/phishing-controller": "5.0.0-preview.746bcb9",
  "@metamask/preferences-controller": "4.2.0-preview.746bcb9",
  "@metamask/rate-limit-controller": "3.0.0-preview.746bcb9",
  "@metamask/signature-controller": "5.2.0-preview.746bcb9",
  "@metamask/transaction-controller": "7.0.0-preview.746bcb9"
}

@shanejonas
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask/address-book-controller": "3.0.0-preview.8e12d1f",
  "@metamask/announcement-controller": "4.0.0-preview.8e12d1f",
  "@metamask/approval-controller": "3.4.0-preview.8e12d1f",
  "@metamask/assets-controllers": "10.0.0-preview.8e12d1f",
  "@metamask/base-controller": "3.1.0-preview.8e12d1f",
  "@metamask/composable-controller": "3.0.0-preview.8e12d1f",
  "@metamask/controller-utils": "4.1.0-preview.8e12d1f",
  "@metamask/ens-controller": "4.0.0-preview.8e12d1f",
  "@metamask/gas-fee-controller": "6.0.1-preview.8e12d1f",
  "@metamask/keyring-controller": "6.0.0-preview.8e12d1f",
  "@metamask/logging-controller": "1.0.0-preview.8e12d1f",
  "@metamask/message-manager": "7.0.2-preview.8e12d1f",
  "@metamask/network-controller": "10.3.0-preview.8e12d1f",
  "@metamask/notification-controller": "3.0.0-preview.8e12d1f",
  "@metamask/permission-controller": "4.0.1-preview.8e12d1f",
  "@metamask/phishing-controller": "5.0.0-preview.8e12d1f",
  "@metamask/preferences-controller": "4.2.0-preview.8e12d1f",
  "@metamask/rate-limit-controller": "3.0.0-preview.8e12d1f",
  "@metamask/signature-controller": "5.2.0-preview.8e12d1f",
  "@metamask/transaction-controller": "7.0.0-preview.8e12d1f"
}

@shanejonas
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask/address-book-controller": "3.0.0-preview.a210685",
  "@metamask/announcement-controller": "4.0.0-preview.a210685",
  "@metamask/approval-controller": "3.4.0-preview.a210685",
  "@metamask/assets-controllers": "10.0.0-preview.a210685",
  "@metamask/base-controller": "3.1.0-preview.a210685",
  "@metamask/composable-controller": "3.0.0-preview.a210685",
  "@metamask/controller-utils": "4.1.0-preview.a210685",
  "@metamask/ens-controller": "4.0.0-preview.a210685",
  "@metamask/gas-fee-controller": "6.0.1-preview.a210685",
  "@metamask/keyring-controller": "6.0.0-preview.a210685",
  "@metamask/logging-controller": "1.0.0-preview.a210685",
  "@metamask/message-manager": "7.0.2-preview.a210685",
  "@metamask/network-controller": "10.3.0-preview.a210685",
  "@metamask/notification-controller": "3.0.0-preview.a210685",
  "@metamask/permission-controller": "4.0.1-preview.a210685",
  "@metamask/phishing-controller": "5.0.0-preview.a210685",
  "@metamask/preferences-controller": "4.2.0-preview.a210685",
  "@metamask/rate-limit-controller": "3.0.0-preview.a210685",
  "@metamask/signature-controller": "5.2.0-preview.a210685",
  "@metamask/transaction-controller": "7.0.0-preview.a210685"
}

@shanejonas
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask/address-book-controller": "3.0.0-preview.4328939",
  "@metamask/announcement-controller": "4.0.0-preview.4328939",
  "@metamask/approval-controller": "3.4.0-preview.4328939",
  "@metamask/assets-controllers": "10.0.0-preview.4328939",
  "@metamask/base-controller": "3.1.0-preview.4328939",
  "@metamask/composable-controller": "3.0.0-preview.4328939",
  "@metamask/controller-utils": "4.1.0-preview.4328939",
  "@metamask/ens-controller": "4.0.0-preview.4328939",
  "@metamask/gas-fee-controller": "6.0.1-preview.4328939",
  "@metamask/keyring-controller": "6.0.0-preview.4328939",
  "@metamask/logging-controller": "1.0.0-preview.4328939",
  "@metamask/message-manager": "7.0.2-preview.4328939",
  "@metamask/network-controller": "10.3.0-preview.4328939",
  "@metamask/notification-controller": "3.0.0-preview.4328939",
  "@metamask/permission-controller": "4.0.1-preview.4328939",
  "@metamask/phishing-controller": "5.0.0-preview.4328939",
  "@metamask/preferences-controller": "4.2.0-preview.4328939",
  "@metamask/rate-limit-controller": "3.0.0-preview.4328939",
  "@metamask/signature-controller": "5.2.0-preview.4328939",
  "@metamask/transaction-controller": "7.0.0-preview.4328939"
}

@shanejonas
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask/address-book-controller": "3.0.0-preview.6f82024",
  "@metamask/announcement-controller": "4.0.0-preview.6f82024",
  "@metamask/approval-controller": "3.4.0-preview.6f82024",
  "@metamask/assets-controllers": "10.0.0-preview.6f82024",
  "@metamask/base-controller": "3.1.0-preview.6f82024",
  "@metamask/composable-controller": "3.0.0-preview.6f82024",
  "@metamask/controller-utils": "4.1.0-preview.6f82024",
  "@metamask/ens-controller": "4.0.0-preview.6f82024",
  "@metamask/gas-fee-controller": "6.0.1-preview.6f82024",
  "@metamask/keyring-controller": "6.0.0-preview.6f82024",
  "@metamask/logging-controller": "1.0.0-preview.6f82024",
  "@metamask/message-manager": "7.0.2-preview.6f82024",
  "@metamask/network-controller": "10.3.0-preview.6f82024",
  "@metamask/notification-controller": "3.0.0-preview.6f82024",
  "@metamask/permission-controller": "4.0.1-preview.6f82024",
  "@metamask/phishing-controller": "5.0.0-preview.6f82024",
  "@metamask/preferences-controller": "4.2.0-preview.6f82024",
  "@metamask/rate-limit-controller": "3.0.0-preview.6f82024",
  "@metamask/signature-controller": "5.2.0-preview.6f82024",
  "@metamask/transaction-controller": "7.0.0-preview.6f82024"
}

@BelfordZ BelfordZ force-pushed the use-registry-from-network-controller branch from 6f82024 to 8d71883 Compare July 19, 2023 17:13
@BelfordZ
Copy link
Contributor

@metamaskbot publish-preview

1 similar comment
@adonesky1
Copy link
Contributor

@metamaskbot publish-preview

@legobeat
Copy link
Contributor

I'm not sure if it will publish before linting passes: https://github.com/MetaMask/core/actions/runs/5602107717/jobs/10246943671?pr=1507#step:5:143

@mcmire
Copy link
Contributor

mcmire commented Aug 14, 2023 •
edited
Loading

@shanejonas @BelfordZ Is this PR open for review, or is it still in progress?

@jiexi
Copy link
Contributor

jiexi commented Aug 25, 2023

@metamaskbot publish-preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shanejonas @BelfordZ @adonesky1 @legobeat @mcmire @jiexi