Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accounts-controller: remove support for major node versions 16-17,19 #2034

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

accounts-controller: remove support for major node versions 16-17,19 #2034

wants to merge 1 commit into from

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Nov 14, 2023 •
edited
Loading

Explanation

References

Changelog

@metamask/accounts-controller

  • CHANGED: BREAKING: Increase minimum Node.js version from 16 to 18.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@NicholasEllul
Copy link
Contributor

Noting the CI error:

➤ YN0038: @metamask/accounts-controller must have a field engines.node set to ">=16.0.0", but is set to "^18.16 || >=20" instead

NicholasEllul
NicholasEllul reviewed Nov 30, 2023
View reviewed changes
Copy link
Contributor

@NicholasEllul NicholasEllul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please re-request a review once ready (my daily reminders aren't smart enough to know this PR is in draft form)

@mcmire mcmire removed their request for review March 22, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicholasEllul NicholasEllul NicholasEllul left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@legobeat @NicholasEllul