Skip to content

Commit

Permalink
feat: Revert disable stx opt-in modal (#24715) (#24845)
Browse files Browse the repository at this point in the history
Once this is merged, this PR will be cherry-picked into 11.16.1

This reverts commit 20e51e6.

Per discussion relating to the feature flag http request for stx, we are
re-enabling the stx opt-in-modal.

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/24845?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
dbrans authored May 28, 2024
1 parent 2a2dfb4 commit abc0268
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions ui/pages/home/home.component.js
Original file line number Diff line number Diff line change
Expand Up @@ -846,10 +846,8 @@ export default class Home extends PureComponent {
!process.env.IN_TEST &&
!newNetworkAddedConfigurationId;

// TODO(dbrans): temporary fix to disable the smart transactions opt-in modal
// in 11.15 to unblock the release. Change this line in 11.16.
const showSmartTransactionsOptInModal =
false && canSeeModals && isSmartTransactionsOptInModalAvailable;
canSeeModals && isSmartTransactionsOptInModalAvailable;

const showWhatsNew =
canSeeModals &&
Expand Down

0 comments on commit abc0268

Please sign in to comment.