Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Upgrade hw-app-eth library to v6.42.0 for Ledger Clear Signing #29813

Open
vivek-consensys opened this issue Jan 21, 2025 · 2 comments · May be fixed by #29820
Open

[Bug] Upgrade hw-app-eth library to v6.42.0 for Ledger Clear Signing #29813

vivek-consensys opened this issue Jan 21, 2025 · 2 comments · May be fixed by #29820
Assignees
@dawnseeker8
Labels
hardware-ledger INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. QA Passed Sev2-normal Normal severity; minor loss of service or inconvenience. team-accounts team-hardware-wallets type-bug

Comments

@vivek-consensys
Copy link

vivek-consensys commented Jan 21, 2025 •
edited
Loading

  • Without 6.42.0, when EIP-712 content is not sorted as defined in solidity struct “types” , the user can be blocked.
  • Without 6.41.0, for some legacy transaction (type 0), the v signature can be wrong and the transaction won’t be broadcasted

Thread: https://consensys.slack.com/archives/C02CYKAA8G1/p1737381638976519?thread_ts=1737106010.543919&cid=C02CYKAA8G1
@vivek-consensys vivek-consensys added hardware-ledger Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. team-hardware-wallets type-bug labels Jan 21, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Jan 21, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Jan 21, 2025
@metamaskbot metamaskbot added the INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. label Jan 21, 2025
@dawnseeker8
Copy link
Contributor

PR has been created in account repo . MetaMask/accounts#153

will upgrade in extension repo after above PR release.

@dawnseeker8 dawnseeker8 linked a pull request Jan 21, 2025 that will close this issue
Open
7 tasks
@vivek-consensys vivek-consensys added QA Passed Sev2-normal Normal severity; minor loss of service or inconvenience. and removed Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. labels Jan 23, 2025
@Akaryatrh Akaryatrh mentioned this issue Jan 23, 2025
Merged
7 tasks
dbrans pushed a commit that referenced this issue Jan 23, 2025
@Akaryatrh @dawnseeker8 @metamaskbot
feat: upgrade ledger keyring to fix EIP-712 issues (#29874)
e8b9a50 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
Ledger team request us to upgrade the @ledgerhq/hw-app-eth to 6.42.0 to
fix ledger bug for EIP-712 content
Here is some comment from Kevin LAMBERT from ledger team:



and this is original thread
https://consensys.slack.com/archives/C02CYKAA8G1/p1737132760664329?thread_ts=1737106010.543919&cid=C02CYKAA8G1



<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29820?quickstart=1)

## **Related issues**

Fixes: #29813 

## **Manual testing steps**
Will require a full regression test for ledger feature.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Xiaoming Wang <[email protected]>
Co-authored-by: MetaMask Bot <[email protected]>
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Jan 24, 2025
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Jan 24, 2025
@angelcheung22 angelcheung22 reopened this Jan 24, 2025
@github-project-automation github-project-automation bot moved this from Fixed to To be fixed in Bugs by team Jan 24, 2025
@gantunesr
Copy link
Member

@danroc @ccharly and/or @darioAnongba will help with dev review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dawnseeker8 dawnseeker8

Labels
hardware-ledger INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. QA Passed Sev2-normal Normal severity; minor loss of service or inconvenience. team-accounts team-hardware-wallets type-bug
Projects
Bugs by severity
Archived in project
Bugs by team
Status: To be fixed
Milestone
No milestone
5 participants
@dawnseeker8 @gantunesr @metamaskbot @angelcheung22 @vivek-consensys