-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade ledger keyring to fix EIP-712 issues #29874
Merged
dbrans
merged 7 commits into
Version-v12.11.0
from
feat/cherry-pick-upgrade-ledger-library
Jan 23, 2025
Merged
feat: upgrade ledger keyring to fix EIP-712 issues #29874
dbrans
merged 7 commits into
Version-v12.11.0
from
feat/cherry-pick-upgrade-ledger-library
Jan 23, 2025
+101
−213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve to confirmation dialog button always disabled for ledger.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
@metamaskbot update-policies |
No policy changes |
Builds ready [234571b]
Page Load Metrics (1518 ± 46 ms)
|
dbrans
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ledger team request us to upgrade the @ledgerhq/hw-app-eth to 6.42.0 to fix ledger bug for EIP-712 content
Here is some comment from Kevin LAMBERT from ledger team:
and this is original thread https://consensys.slack.com/archives/C02CYKAA8G1/p1737132760664329?thread_ts=1737106010.543919&cid=C02CYKAA8G1
main
branch. This can be explained by the fact that#withKeyringForDevice
function frommetamask-controller
is not part ofVersion-v12.11.0
branch, but exists only onmain
branch.As a demonstration, here's an extract of the diff between
Version-v12.11.0
andfeat/upgrade-ledger-library
branches (the latter being used on the PR in front ofmain
)Related issues
Fixes: #29813
Please also see related PR for
main
branch: #29820Manual testing steps
Will require a full regression test for ledger feature.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist