Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure SRP backup reminder only displays when on HDKey account #29857

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Jan 22, 2025

Description

Ensures that the SRP backup reminder only displays if the user is on HD keyring, so will not display if the user is on hardware wallet or imported wallet

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Create a new wallet and do NOT backup SRP
  2. Finish onboarding, see SRP reminder
  3. Import a new account, do NOT see SRP reminder
  4. Add hardware wallet account, do NOT see SRP reminder

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants