-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove MMI UI code #29884
Open
shane-t
wants to merge
5
commits into
main
Choose a base branch
from
29782-remove-mmi-ui-code
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
chore: remove MMI UI code #29884
+157
−19,620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shane-t
force-pushed
the
29782-remove-mmi-ui-code
branch
6 times, most recently
from
January 24, 2025 01:10
9d8b59d
to
b470fab
Compare
Builds ready [9d8b59d]
Page Load Metrics (2066 ± 269 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
9 tasks
shane-t
force-pushed
the
29782-remove-mmi-ui-code
branch
from
January 24, 2025 01:37
d7d5042
to
749bfb1
Compare
shane-t
commented
Jan 24, 2025
@@ -61,6 +61,7 @@ export enum IconName { | |||
Connect = 'connect', | |||
CopySuccess = 'copy-success', | |||
Copy = 'copy', | |||
Custody = 'custody', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The snaps SDK exports a type that contains this, so we can't remove this without causing typescript errors
Builds ready [749bfb1]
Page Load Metrics (1869 ± 86 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Builds ready [c407b74]
Page Load Metrics (1688 ± 91 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of the MMI deprecation and code removal, it's necessary to remove the fenced UI code before the background code, since the UI code is lower in the dependency chain.
This PR removes any code that's inside a @build-mmi code fence. In order to satisfy various requirements this also means removing unused imports, which the PR also deletes.
The PR also removes tests (which have never been code fenced) because in many cases they are caused by fenced code.
In addition, any non-fenced code which is known to be MMI specific is removed.
It does not remove inverse MMI code fences, i.e. fences which are there to stop things running in MMI and are now redundant. This is for the sake of keeping the PR a bit smaller. Those will be removed in the next PR.
Related issues
Fixes: #29782
Manual testing steps
Not applicable, as no new feature is added. However, many/most UI features are touched.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist