feat: Conditionally disable nonce editing when smart transactions are…

[pedronfigueiredo]

… enabled

Description

We recently enabled custom nonce editing in all redesigned flows, independently of the custom nonce editing settings toggle. This toggle was still used in the legacy flows that are no longer visible by the user, and it will be removed soon in an upcoming PR.

This resulted in nonce editing being available for smart transactions which is not needed as the user should never need to manipulate nonces of smart transactions. This PR fixes this by removing that option to the user.

If smart transactions are enabled but the transaction is on a chain that doesn't currently support smart transactions, the nonce is still editable.

Related issues

Fixes: #29841

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[dan437]

Nice, I've tried it and don't see nonce editing anymore on the new Confirmation page for STX.

[metamaskbot]

Builds ready [3530c92]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1900 ± 51 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	215	2028	1589	598	287
		domContentLoaded	1714	2124	1878	100	48
		load	1725	2129	1900	107	51
		domInteractive	27	120	50	27	13
		backgroundConnect	8	58	21	16	8
		firstReactRender	18	103	42	25	12
		getState	6	58	15	14	7
		initialActions	0	48	3	10	5
		loadScripts	1240	1633	1387	101	49
		setupStore	6	71	22	22	10
		uiStartup	1941	2584	2182	148	71

Bundle size diffs [🚀 Bundle size reduced!]

• background: 1.02 KiB (0.02%)
• ui: 1.65 KiB (0.02%)
• common: -40.51 KiB (-0.45%)