Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated permissions header to be consistent (#29880) #29893

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Jan 24, 2025

Cherry picks 2263ce4 (#29880)

Original PR Description

This PR is to update the title of the Dapp in all the connection steps

Fixes: #29785

  1. Connect MM to a Dapp
  2. Check the correct Dapp Url is shown through all screens while connecting
404338198-60256b44-59b6-47ec-9c0f-aeeec0ef2b45.mov
Screen.Recording.2025-01-23.at.5.13.23.PM.mov
Screen.Recording.2025-01-23.at.5.14.44.PM.mov
  • I've followed MetaMask Contributor Docs and MetaMask Extension Coding
    Standards
    .

  • I've completed the PR template to the best of my ability

  • I’ve included tests if applicable

  • I’ve documented my code using JSDoc format if applicable

  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).

  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

This PR is to update the title of the Dapp in all the connection steps

Fixes: #29785

1. Connect MM to a Dapp
2. Check the correct Dapp Url is shown through all screens while
connecting

https://github.com/user-attachments/assets/bedde663-5546-45cf-8d41-bc09441844d4

https://github.com/user-attachments/assets/03a85c6a-942e-420e-bb46-bd5d252ddfc9

https://github.com/user-attachments/assets/28ee358c-fd2c-4476-ad75-41a55e1b0efd

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@metamaskbot
Copy link
Collaborator

Builds ready [14024e4]
Page Load Metrics (1752 ± 67 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint53221481693300144
domContentLoaded14922121171713264
load15022150175213967
domInteractive2699452512
backgroundConnect1181372512
firstReactRender1679352311
getState66416157
initialActions01000
loadScripts11081583127010048
setupStore65511105
uiStartup17132475199816881

@dbrans dbrans merged commit 51146c0 into Version-v12.10.2 Jan 24, 2025
72 checks passed
@dbrans dbrans deleted the cherry-pick-2263ce4 branch January 24, 2025 15:37
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants