fix: snapshots

MetaMask · httpJunkie · Jan 28, 2025 · Jan 27, 2025 · Jan 27, 2025 · Jan 27, 2025
commit de01a18192f9554d2bdcdd267c2fc9dc0dce23ba
diff --git a/ui/components/app/snaps/snap-ui-address/__snapshots__/snap-ui-address.test.tsx.snap b/ui/components/app/snaps/snap-ui-address/__snapshots__/snap-ui-address.test.tsx.snap
@@ -172,7 +172,7 @@ exports[`SnapUIAddress renders Ethereum address 1`] = `
           <rect
             fill="#F29602"
             height="32"
-            transform="translate(-2.81750896228304 4.951916544006229) rotate(230.4 16 16)"
+            transform="translate(-2.8175089622830405 4.951916544006229) rotate(230.4 16 16)"
             width="32"
             x="0"
             y="0"
@@ -476,7 +476,7 @@ exports[`SnapUIAddress renders legacy Ethereum address 1`] = `
           <rect
             fill="#F29602"
             height="32"
-            transform="translate(-2.81750896228304 4.951916544006229) rotate(230.4 16 16)"
+            transform="translate(-2.8175089622830405 4.951916544006229) rotate(230.4 16 16)"
             width="32"
             x="0"
             y="0"

diff --git a/app/scripts/controllers/swaps/swaps.test.ts b/app/scripts/controllers/swaps/swaps.test.ts

      // TODO: Re think how to test this without exposing internal state

      // it('should replace ethers instance when called with a different chainId than was current when the controller was instantiated', async function () {
      //   fetchTradesInfoStub.mockReset();

      //   const _swapsController = getSwapsController();
      //   expect(currentEthersInstance).not.toStrictEqual(newEthersInstance);
      // });

      // it('should not replace ethers instance when called with the same chainId that was current when the controller was instantiated', async function () {
      //   const _swapsController = new SwapsController({
      //     getBufferedGasLimit: MOCK_GET_BUFFERED_GAS_LIMIT,
      //     provider,
      //   expect(currentEthersInstance).toStrictEqual(newEthersInstance);
      // });

      // it('should replace ethers instance, and _ethersProviderChainId, twice when called twice with two different chainIds, and successfully set the _ethersProviderChainId when returning to the original chain', async function () {
      //   const _swapsController = new SwapsController({
      //     getBufferedGasLimit: MOCK_GET_BUFFERED_GAS_LIMIT,
      //     provider,
        });
      });

      // it('clears polling timeout', function () {
      //   swapsController._pollingTimeout = setTimeout(() => {
      //     throw new Error('Polling timeout not cleared');
      //   }, POLLING_TIMEOUT);
    describe('stopPollingForQuotes', function () {
      // TODO: Re think how to test this without exposing internal state

      // it('clears polling timeout', function () {
      //   swapsController._pollingTimeout = setTimeout(() => {
      //     throw new Error('Polling timeout not cleared');
      //   }, POLLING_TIMEOUT);
    describe('resetPostFetchState', function () {
      // TODO: Re think how to test this without exposing internal state

      // it('clears polling timeout', function () {
      //   swapsController._pollingTimeout = setTimeout(() => {
      //     throw new Error('Polling timeout not cleared');
      //   }, POLLING_TIMEOUT);
diff --git a/ui/components/app/detected-token/detected-token.js b/ui/components/app/detected-token/detected-token.js
    };

    setTokensListDetected(newTokensList());
  }, [
    isTokenNetworkFilterEqualCurrentNetwork,
    detectedTokensMultichain,
    detectedTokens,
diff --git a/ui/components/app/name/name.stories.tsx b/ui/components/app/name/name.stories.tsx
 * No name has been saved for the value and type.
 */
 export const NoSavedName = {
  name: 'No Saved Name',
  args: {
    value: ADDRESS_MOCK,
    type: NameType.ETHEREUM_ADDRESS,
diff --git a/ui/components/app/snaps/snap-home-page/snap-home-renderer.js b/ui/components/app/snaps/snap-home-page/snap-home-renderer.js

  useEffect(() => {
    return () => interfaceId && dispatch(deleteInterface(interfaceId));
  }, [interfaceId]);

  useEffect(() => {
    // Snaps are allowed to redirect to their own pending confirmations (templated or not)
    } else if (snapApproval) {
      history.push(`${CONFIRM_TRANSACTION_ROUTE}/${snapApproval.id}`);
    }
  }, [unapprovedTemplatedConfirmations, unapprovedConfirmations, history]);

  if (error) {
    return (

	// TODO: Re think how to test this without exposing internal state

	// it('should replace ethers instance when called with a different chainId than was current when the controller was instantiated', async function () {
Check warning on line 1265 in app/scripts/controllers/swaps/swaps.test.ts GitHub Actions / Test lint / Test lint `Some tests seem to be commented`
	// fetchTradesInfoStub.mockReset();

	// const _swapsController = getSwapsController();
	// expect(currentEthersInstance).not.toStrictEqual(newEthersInstance);
	// });

	// it('should not replace ethers instance when called with the same chainId that was current when the controller was instantiated', async function () {
Check warning on line 1286 in app/scripts/controllers/swaps/swaps.test.ts GitHub Actions / Test lint / Test lint `Some tests seem to be commented`
	// const _swapsController = new SwapsController({
	// getBufferedGasLimit: MOCK_GET_BUFFERED_GAS_LIMIT,
	// provider,
	// expect(currentEthersInstance).toStrictEqual(newEthersInstance);
	// });

	// it('should replace ethers instance, and _ethersProviderChainId, twice when called twice with two different chainIds, and successfully set the _ethersProviderChainId when returning to the original chain', async function () {
Check warning on line 1306 in app/scripts/controllers/swaps/swaps.test.ts GitHub Actions / Test lint / Test lint `Some tests seem to be commented`
	// const _swapsController = new SwapsController({
	// getBufferedGasLimit: MOCK_GET_BUFFERED_GAS_LIMIT,
	// provider,
	});
	});

	// it('clears polling timeout', function () {
Check warning on line 1390 in app/scripts/controllers/swaps/swaps.test.ts GitHub Actions / Test lint / Test lint `Some tests seem to be commented`
	// swapsController._pollingTimeout = setTimeout(() => {
	// throw new Error('Polling timeout not cleared');
	// }, POLLING_TIMEOUT);
	describe('stopPollingForQuotes', function () {
	// TODO: Re think how to test this without exposing internal state

	// it('clears polling timeout', function () {
Check warning on line 1406 in app/scripts/controllers/swaps/swaps.test.ts GitHub Actions / Test lint / Test lint `Some tests seem to be commented`
	// swapsController._pollingTimeout = setTimeout(() => {
	// throw new Error('Polling timeout not cleared');
	// }, POLLING_TIMEOUT);
	describe('resetPostFetchState', function () {
	// TODO: Re think how to test this without exposing internal state

	// it('clears polling timeout', function () {
Check warning on line 1429 in app/scripts/controllers/swaps/swaps.test.ts GitHub Actions / Test lint / Test lint `Some tests seem to be commented`
	// swapsController._pollingTimeout = setTimeout(() => {
	// throw new Error('Polling timeout not cleared');
	// }, POLLING_TIMEOUT);
	};

	setTokensListDetected(newTokensList());
	}, [
Check warning on line 117 in ui/components/app/detected-token/detected-token.js GitHub Actions / Test lint / Test lint `React Hook useEffect has a missing dependency: 'tokensListDetected'. Either include it or remove the dependency array`
	isTokenNetworkFilterEqualCurrentNetwork,
	detectedTokensMultichain,
	detectedTokens,
	* No name has been saved for the value and type.
	*/
	export const NoSavedName = {
	name: 'No Saved Name',
Check warning on line 129 in ui/components/app/name/name.stories.tsx GitHub Actions / Test lint / Test lint `Named exports should not use the name annotation if it is redundant to the name that would be generated by the export name`
	args: {
	value: ADDRESS_MOCK,
	type: NameType.ETHEREUM_ADDRESS,

	useEffect(() => {
	return () => interfaceId && dispatch(deleteInterface(interfaceId));
	}, [interfaceId]);
Check warning on line 49 in ui/components/app/snaps/snap-home-page/snap-home-renderer.js GitHub Actions / Test lint / Test lint `React Hook useEffect has a missing dependency: 'dispatch'. Either include it or remove the dependency array`

	useEffect(() => {
	// Snaps are allowed to redirect to their own pending confirmations (templated or not)
	} else if (snapApproval) {
	history.push(`${CONFIRM_TRANSACTION_ROUTE}/${snapApproval.id}`);
	}
	}, [unapprovedTemplatedConfirmations, unapprovedConfirmations, history]);
Check warning on line 65 in ui/components/app/snaps/snap-home-page/snap-home-renderer.js GitHub Actions / Test lint / Test lint `React Hook useEffect has a missing dependency: 'snapId'. Either include it or remove the dependency array`

	if (error) {
	return (