Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reapply the fix for seeing you received when bridge tx not finished #29933

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

infiniteflower
Copy link
Contributor

@infiniteflower infiniteflower commented Jan 27, 2025

Description

Open in GitHub Codespaces

This PR reapplies the fixes from #29411.

This PR fixes an issue where the "You Received" row in the Activity item for a bridge tx would be partially filled in. Now we just hide it until the bridge tx completes and we have all the necessary data to display the row properly.

Related issues

Reapplies the fixes from #29411

Manual testing steps

  1. Start a bridge tx
  2. Get navigated to Activity list
  3. Click on bridge tx
  4. Observe that "You received" is not present until the bridge is completed.

Screenshots/Recordings

Before

After

Screen.Recording.2025-01-27.at.3.20.00.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@infiniteflower infiniteflower marked this pull request as ready for review January 27, 2025 20:21
@infiniteflower infiniteflower requested a review from a team as a code owner January 27, 2025 20:21
@metamaskbot
Copy link
Collaborator

Builds ready [43d8cdf]
Page Load Metrics (1640 ± 63 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14931960163912259
domContentLoaded14561915161912460
load14871964164013163
domInteractive238035168
backgroundConnect96623178
firstReactRender1696413014
getState45810147
initialActions01000
loadScripts10141438115911957
setupStore881192110
uiStartup166326731912217104
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 47 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@infiniteflower infiniteflower added this pull request to the merge queue Jan 28, 2025
Merged via the queue into main with commit 2cf7e67 Jan 28, 2025
88 checks passed
@infiniteflower infiniteflower deleted the fix/reapply-mb1834-xchain-you-received branch January 28, 2025 20:46
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2025
@metamaskbot metamaskbot added the release-12.12.0 Issue or pull request that will be included in release 12.12.0 label Jan 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.12.0 Issue or pull request that will be included in release 12.12.0 team-bridge team-swaps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants