Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: smart transaction e2e #29935

Merged
merged 4 commits into from
Jan 28, 2025
Merged

test: smart transaction e2e #29935

merged 4 commits into from
Jan 28, 2025

Conversation

matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Jan 27, 2025

Description

Enable the existing smart swap E2E test.

Add a new test for smart transactions triggered by dApp request.

Open in GitHub Codespaces

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@matthewwalsh0 matthewwalsh0 added the team-confirmations Push issues to confirmations team label Jan 27, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [e8cbe05]
Page Load Metrics (1661 ± 74 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14462018166215776
domContentLoaded14321979163915172
load14411996166115474
domInteractive24453163
backgroundConnect106422178
firstReactRender1696452813
getState45820199
initialActions01000
loadScripts10161430119612259
setupStore861202010
uiStartup168225581948220106
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [0755982]
Page Load Metrics (1557 ± 55 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint27118471492305146
domContentLoaded13381832153512359
load13711846155711555
domInteractive2274432010
backgroundConnect95932199
firstReactRender1594332412
getState417732
initialActions01000
loadScripts928130611129947
setupStore77614178
uiStartup15872244177416378
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@matthewwalsh0 matthewwalsh0 added this pull request to the merge queue Jan 28, 2025
Merged via the queue into main with commit 39e4fbe Jan 28, 2025
70 checks passed
@matthewwalsh0 matthewwalsh0 deleted the test/smart-transaction-e2e branch January 28, 2025 12:23
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2025
@metamaskbot metamaskbot added the release-12.12.0 Issue or pull request that will be included in release 12.12.0 label Jan 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.12.0 Issue or pull request that will be included in release 12.12.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants