-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix send flow max value issue #29960
Merged
Merged
+148
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedronfigueiredo
approved these changes
Jan 29, 2025
vinistevam
approved these changes
Jan 29, 2025
Builds ready [ce4e74f]
Page Load Metrics (1667 ± 73 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Max amount is adjusted in response to Gas settings / fluctuations and the Max amount transaction can be successfully sent: max_amount_gas.movgas_settings.mov |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 29, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 29, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR aims to fix send max value issue for redesigned confirmations. [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29960?quickstart=1) ## **Related issues** Fixes: #29903 ## **Manual testing steps** 1. Initiate a native send flow from wallet 2. Click max in the amount picker 3. Go to next step (confirmation) 4. See that value changes when gas is changed ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> https://github.com/user-attachments/assets/14a85e29-b7d5-4bfe-b013-25f1954103cc ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 29, 2025
…ceeds-available-funds-no-warning-is-displayed-to-alert-the-user-max-amount-is-not-adjusted-in-response-to-gas-fees-changes
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…ceeds-available-funds-no-warning-is-displayed-to-alert-the-user-max-amount-is-not-adjusted-in-response-to-gas-fees-changes
Builds ready [ee78204]
Page Load Metrics (1853 ± 151 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
OGPoyraz
deleted the
29903-bug-bug-when-the-transaction-amount-exceeds-available-funds-no-warning-is-displayed-to-alert-the-user-max-amount-is-not-adjusted-in-response-to-gas-fees-changes
branch
January 29, 2025 23:59
metamaskbot
added
the
release-12.12.0
Issue or pull request that will be included in release 12.12.0
label
Jan 30, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
QA Passed
release-12.12.0
Issue or pull request that will be included in release 12.12.0
team-confirmations
Push issues to confirmations team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix send max value issue for redesigned confirmations.
Related issues
Fixes: #29903
Manual testing steps
Screenshots/Recordings
SendFlowMaxAmount.mov
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist