Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version v12.10.3 #29972

Merged
merged 4 commits into from
Jan 29, 2025
Merged

Version v12.10.3 #29972

merged 4 commits into from
Jan 29, 2025
+15 −10

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Jan 29, 2025 •
edited
Loading

[12.10.3]

Fixed

  • fix: ensure recipient address is shown on when sending erc 1155 tokens (#29775)

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added team-extension-platform INVALID-PR-TEMPLATE PR's body doesn't match template release-12.10.3 Issue or pull request that will be included in release 12.10.3 labels Jan 29, 2025
danjm and others added 2 commits January 29, 2025 13:25
@danjm @ccharly
fix: fix undici audit (5.28.4 -> 5.28.5) (#29914) (#29976)
c14626e 
cherry-picks b57ed09 to v12.10.3

```console
$ yarn audit
└─ undici
   ├─ ID: 1101610
   ├─ Issue: Use of Insufficiently Random Values in undici
   ├─ URL: GHSA-c76h-2ccp-4975
   ├─ Severity: moderate
   ├─ Vulnerable Versions: >=4.5.0 <5.28.5
   │
   ├─ Tree Versions
   │  └─ 5.28.4
   │
   └─ Dependents
      └─ @firebase/auth-compat@npm:0.5.6 [35f05]
```

[![Open in GitHub

Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29914?quickstart=1)

Fixes: GHSA-c76h-2ccp-4975

N/A

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding

Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29976?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Co-authored-by: Charly Chevalier <[email protected]>
@pedronfigueiredo
fix: Transaction flow component for 1155 token send (#29973)
c97c6a0 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This PR is intended to patch in v12.10.3 a bug that [was fixed on
v12.12.0](#29775).

That fix included a change to a file that [was only created on
v12.11.00](https://github.com/MetaMask/metamask-extension/pull/29389/files#diff-d78d0997a77c00d76a87390c384fda0043059509d31a577b5b4573818d064f3c),
so instead of cherry-picked, the change was reimplemented manually.

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29973?quickstart=1)

## **Related issues**

Fixes: 

## **Manual testing steps**

1. Initiate send of a 1155 NFT.
2. The recipient address should be correctly displayed (see attached
ticket for screenshots)

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@socket-security Socket Security
Copy link

socket-security bot commented Jan 29, 2025 •
edited
Loading

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@fastify/[email protected], npm/[email protected]

View full report↗︎

@danjm
Copy link
Contributor Author

danjm commented Jan 29, 2025

@metamaskbot update-attributions

@metamaskbot
Copy link
Collaborator

Attributions updated

@danjm danjm marked this pull request as ready for review January 29, 2025 19:25
@danjm danjm requested a review from a team as a code owner January 29, 2025 19:25
@dbrans dbrans added the DO-NOT-MERGE Pull requests that should not be merged label Jan 29, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [78dae0f]
Page Load Metrics (1635 ± 50 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint29318771563308148
domContentLoaded14811862160610148
load14901878163510550
domInteractive20106472713
backgroundConnect994312311
firstReactRender1594352512
getState4471094
initialActions00000
loadScripts1069140711959747
setupStore66110126
uiStartup17032463186918086

@dbrans
Copy link
Contributor

dbrans commented Jan 29, 2025

@dbrans dbrans removed the DO-NOT-MERGE Pull requests that should not be merged label Jan 29, 2025
@danjm danjm merged commit cdc2786 into master Jan 29, 2025
77 checks passed
@danjm danjm deleted the Version-v12.10.3 branch January 29, 2025 20:26
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@itsyoboieltr itsyoboieltr itsyoboieltr approved these changes

Assignees
No one assigned
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-12.10.3 Issue or pull request that will be included in release 12.10.3 team-extension-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@danjm @metamaskbot @dbrans @itsyoboieltr @pedronfigueiredo