Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Transaction flow component for 1155 token send #29973

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

pedronfigueiredo
Copy link
Contributor

@pedronfigueiredo pedronfigueiredo commented Jan 29, 2025

Description

This PR is intended to patch in v12.10.3 a bug that was fixed on v12.12.0.

That fix included a change to a file that was only created on v12.11.00, so instead of cherry-picked, the change was reimplemented manually.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Initiate send of a 1155 NFT.
  2. The recipient address should be correctly displayed (see attached ticket for screenshots)

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pedronfigueiredo pedronfigueiredo added the team-confirmations Push issues to confirmations team label Jan 29, 2025
@pedronfigueiredo pedronfigueiredo self-assigned this Jan 29, 2025
@pedronfigueiredo pedronfigueiredo requested a review from a team as a code owner January 29, 2025 16:23
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [d9d9114]
Page Load Metrics (1886 ± 73 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16872317189715775
domContentLoaded16432302185814972
load16582322188615373
domInteractive27190564120
backgroundConnect11101312311
firstReactRender1796432713
getState565262211
initialActions01000
loadScripts11891721139412560
setupStore765192010
uiStartup19372812217420297

@sleepytanya
Copy link
Contributor

sleepytanya commented Jan 29, 2025

From and To fields are displayed for the ERC 1155 send:

erc1155.mov

@dbrans dbrans merged commit c97c6a0 into Version-v12.10.3 Jan 29, 2025
65 of 68 checks passed
@dbrans dbrans deleted the pnf/cherry-pick-fix-send-nft branch January 29, 2025 18:26
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed team-confirmations Push issues to confirmations team
Projects
None yet
4 participants