Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix undici audit (5.28.4 -> 5.28.5) (#29914) #29976

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Jan 29, 2025

cherry-picks b57ed09 to v12.10.3

$ yarn audit
└─ undici
   ├─ ID: 1101610
   ├─ Issue: Use of Insufficiently Random Values in undici
   ├─ URL: https://github.com/advisories/GHSA-c76h-2ccp-4975
   ├─ Severity: moderate
   ├─ Vulnerable Versions: >=4.5.0 <5.28.5

   ├─ Tree Versions
   │  └─ 5.28.4

   └─ Dependents
      └─ @firebase/auth-compat@npm:0.5.6 [35f05]

Open in GitHub Codespaces

Fixes: GHSA-c76h-2ccp-4975

N/A

  • I've followed MetaMask Contributor Docs and MetaMask Extension Coding
    Standards
    .

  • I've completed the PR template to the best of my ability

  • I’ve included tests if applicable

  • I’ve documented my code using JSDoc format if applicable

  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).

  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

```console
$ yarn audit
└─ undici
   ├─ ID: 1101610
   ├─ Issue: Use of Insufficiently Random Values in undici
   ├─ URL: GHSA-c76h-2ccp-4975
   ├─ Severity: moderate
   ├─ Vulnerable Versions: >=4.5.0 <5.28.5
   │
   ├─ Tree Versions
   │  └─ 5.28.4
   │
   └─ Dependents
      └─ @firebase/auth-compat@npm:0.5.6 [35f05]
```

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29914?quickstart=1)

Fixes: GHSA-c76h-2ccp-4975

N/A

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@fastify/[email protected], npm/[email protected]

View full report↗︎

@metamaskbot
Copy link
Collaborator

Builds ready [2a49430]
Page Load Metrics (1923 ± 108 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint150824251911228109
domContentLoaded148024051863227109
load156524301923225108
domInteractive26177523617
backgroundConnect10183584321
firstReactRender1794372411
getState7105292813
initialActions01000
loadScripts10811936139820498
setupStore75715136
uiStartup181028552201279134

@dbrans dbrans merged commit c14626e into Version-v12.10.3 Jan 29, 2025
68 checks passed
@dbrans dbrans deleted the cherry-pick-b57ed09-to-v12.10.3 branch January 29, 2025 18:25
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants