Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Take DOM snapshots of all windows on failure #29983

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jan 29, 2025

Description

Our e2e test tooling takes a DOM snapshot on test failure to help with debugging. Unfortunately this is not overly useful right now because the driver is always set to the last window handle when this snapshot is taken, which is typically the offscreen document (at least on Chrome). Even on Firefox where there is no offscreen document, it may end up taking a snapshot of the wrong page when there are multiple open.

The DOM snapshot step has been updated to take snapshots of all open pages, rather than just the "current" one.

Open in GitHub Codespaces

Related issues

N/A

Manual testing steps

See the DOM snapshot artifacts in CircleCI upon failure

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

hjetpoluru
hjetpoluru previously approved these changes Jan 29, 2025
seaona
seaona previously approved these changes Jan 29, 2025
@Gudahtt Gudahtt dismissed stale reviews from seaona and hjetpoluru via 8b84fc8 January 29, 2025 19:36
@Gudahtt Gudahtt marked this pull request as ready for review January 29, 2025 19:53
@hjetpoluru hjetpoluru self-requested a review January 29, 2025 19:57
Our e2e test tooling takes a DOM snapshot on test failure to help with
debugging. Unfortunately this is not overly useful right now because
the driver is always set to the last window handle when this snapshot
is taken, which is typically the offscreen document (at least on
Chrome). Even on Firefox where there is no offscreen document, it may
end up taking a snapshot of the wrong page when there are multiple
open.

The DOM snapshot step has been updated to take snapshots of all open
pages, rather than just the "current" one.
@Gudahtt Gudahtt force-pushed the take-dom-snapshots-of-all-open-windows branch from 8b84fc8 to 57c0cec Compare January 29, 2025 22:01
@Gudahtt Gudahtt enabled auto-merge January 29, 2025 22:01
@Gudahtt Gudahtt added this pull request to the merge queue Jan 29, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [57c0cec]
Page Load Metrics (1997 ± 81 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint31522291901398191
domContentLoaded16272223196317082
load16792274199716881
domInteractive26137483014
backgroundConnect1181362311
firstReactRender17179563919
getState692272412
initialActions01000
loadScripts11891716144814871
setupStore86516167
uiStartup189629812353245117
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Merged via the queue into main with commit c00289d Jan 29, 2025
70 checks passed
@Gudahtt Gudahtt deleted the take-dom-snapshots-of-all-open-windows branch January 29, 2025 23:06
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2025
@metamaskbot metamaskbot added the release-12.12.0 Issue or pull request that will be included in release 12.12.0 label Jan 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.12.0 Issue or pull request that will be included in release 12.12.0 team-extension-platform team-wallet-framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants