-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Take DOM snapshots of all windows on failure #29983
Merged
Merged
+17
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjetpoluru
previously approved these changes
Jan 29, 2025
seaona
previously approved these changes
Jan 29, 2025
hjetpoluru
approved these changes
Jan 29, 2025
seaona
approved these changes
Jan 29, 2025
Our e2e test tooling takes a DOM snapshot on test failure to help with debugging. Unfortunately this is not overly useful right now because the driver is always set to the last window handle when this snapshot is taken, which is typically the offscreen document (at least on Chrome). Even on Firefox where there is no offscreen document, it may end up taking a snapshot of the wrong page when there are multiple open. The DOM snapshot step has been updated to take snapshots of all open pages, rather than just the "current" one.
Gudahtt
force-pushed
the
take-dom-snapshots-of-all-open-windows
branch
from
January 29, 2025 22:01
8b84fc8
to
57c0cec
Compare
Builds ready [57c0cec]
Page Load Metrics (1997 ± 81 ms)
Bundle size diffs
|
metamaskbot
added
the
release-12.12.0
Issue or pull request that will be included in release 12.12.0
label
Jan 29, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-12.12.0
Issue or pull request that will be included in release 12.12.0
team-extension-platform
team-wallet-framework
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our e2e test tooling takes a DOM snapshot on test failure to help with debugging. Unfortunately this is not overly useful right now because the driver is always set to the last window handle when this snapshot is taken, which is typically the offscreen document (at least on Chrome). Even on Firefox where there is no offscreen document, it may end up taking a snapshot of the wrong page when there are multiple open.
The DOM snapshot step has been updated to take snapshots of all open pages, rather than just the "current" one.
Related issues
N/A
Manual testing steps
See the DOM snapshot artifacts in CircleCI upon failure
Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist