feat: update patches and unreleased controller utils #30101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Prithpal-Sooriya
commented
Feb 4, 2025
| @@ -291,12 +291,12 @@ | |||
| "@metamask/address-book-controller": "^6.0.0", | |||
| "@metamask/announcement-controller": "^7.0.0", | |||
| "@metamask/approval-controller": "^7.0.0", | |||
| "@metamask/assets-controllers": "patch:@metamask/assets-controllers@npm%3A46.0.1#~/.yarn/patches/@metamask-assets-controllers-npm-46.0.1-3c56f3157c.patch", | |||
| "@metamask/assets-controllers": "patch:@metamask-previews/assets-controllers@47.0.0-preview-33c13522#.yarn/patches/@metamask-assets-controllers-npm-46.0.1-3c56f3157c.patch", | |||
There was a problem hiding this comment.
Preview package with our patch.
TODO - we can cleanup and remove the old unused patches
Prithpal-Sooriya
commented
Feb 4, 2025
| "@metamask/base-controller": "^7.0.0", | ||
| "@metamask/bitcoin-wallet-snap": "^0.9.0", | ||
| "@metamask/browser-passworder": "^4.3.0", | ||
| "@metamask/contract-metadata": "^2.5.0", | ||
| "@metamask/controller-utils": "^11.4.0", | ||
| "@metamask/controller-utils": "npm:@metamask-previews/controller-utils@11.4.5-preview-33c13522", |
There was a problem hiding this comment.
We need to rely on the new controller util changes. TBH this doesn't need to be added, but check the yarn.lock change.
Prithpal-Sooriya
commented
Feb 4, 2025
| "@metamask/abi-utils": "npm:^2.0.3" | ||
| "@metamask/base-controller": "npm:^7.1.1" | ||
| "@metamask/contract-metadata": "npm:^2.4.0" | ||
| "@metamask/controller-utils": "npm:@metamask-previews/[email protected]" |
There was a problem hiding this comment.
HERE - the controller utils has unreleased changes that we need in the assets preview package.
|
closing since we can just copy the changes into our preview test branches. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist