-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Perf: Prevent MultipleNotifications rerenders #30288
base: main
Are you sure you want to change the base?
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [52da8c7]
Page Load Metrics (1795 ± 93 ms)
Bundle size diffs
|
{t('newNetworkAdded', [newNetworkAddedName])} | ||
const items = [ | ||
newNftAddedMessage === 'success' ? ( | ||
<ActionableMessage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm I need to do some reading, but now that this is an array of JSX elements, shouldn't we give these a key
field to ensure that React effectively manages (reconciles) items in this list?
Description
The
MultipleNotifications
component rerenders on a non-matching array ofnull
values. This prevents that issue.Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist