Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Perf: Prevent MultipleNotifications rerenders #30288

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Feb 13, 2025

Description

The MultipleNotifications component rerenders on a non-matching array of null values. This prevents that issue.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@darkwing darkwing requested a review from a team as a code owner February 13, 2025 03:53
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [52da8c7]
Page Load Metrics (1795 ± 93 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint29221381630479230
domContentLoaded15012118176419392
load15102136179519393
domInteractive25108452411
backgroundConnect973342512
firstReactRender1574372411
getState45821199
initialActions00000
loadScripts10901544129315876
setupStore7281142
uiStartup164524742041234113
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 42 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

{t('newNetworkAdded', [newNetworkAddedName])}
const items = [
newNftAddedMessage === 'success' ? (
<ActionableMessage
Copy link
Contributor

@Prithpal-Sooriya Prithpal-Sooriya Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm I need to do some reading, but now that this is an array of JSX elements, shouldn't we give these a key field to ensure that React effectively manages (reconciles) items in this list?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants