Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Perf: Prevent AddressCopyButton rerenders #30289

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Feb 13, 2025

Description

Prevents unwanted rerenders on the AddressCopyButton when props are the same

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@darkwing darkwing requested a review from a team as a code owner February 13, 2025 04:12
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [d889e0c]
Page Load Metrics (1571 ± 46 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1403175715729948
domContentLoaded1395170415529546
load1404175415719746
domInteractive24122402612
backgroundConnect96019136
firstReactRender1597342914
getState471182110
initialActions01000
loadScripts974128011228943
setupStore574212211
uiStartup16242316182618287
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 574 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

@NidhiKJha NidhiKJha added this pull request to the merge queue Feb 18, 2025
Merged via the queue into main with commit e478643 Feb 18, 2025
73 checks passed
@NidhiKJha NidhiKJha deleted the AddressCopyButtonPerf branch February 18, 2025 12:28
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2025
@metamaskbot metamaskbot added the release-12.14.0 Issue or pull request that will be included in release 12.14.0 label Feb 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.14.0 Issue or pull request that will be included in release 12.14.0 team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants