feat: fetch sol quotes + account picker and quote card #30452

micaelae · 2025-02-19T23:11:28Z

Description

We added the ability to fetch SOL quotes and an Account Picker component to select a destination address for SOL <-> EVM bridges. We also modified the quote card to fit a new design.

Related issues

Fixes:

Manual testing steps

Enable solana
Navigate to bridge page
Try a crosschain swap between solana and evm

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-02-25T04:49:18Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-02-25T05:22:13Z

Builds ready [cf022fb]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1572 ± 56 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	344	1850	1392	437	210
		domContentLoaded	1336	1793	1539	118	56
		load	1382	1861	1572	117	56
		domInteractive	22	138	40	25	12
		backgroundConnect	10	86	40	22	11
		firstReactRender	14	77	29	21	10
		getState	5	57	14	15	7
		initialActions	0	1	0	0	0
		loadScripts	983	1365	1134	96	46
		setupStore	7	65	17	20	10
		uiStartup	1546	2095	1786	143	69

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 21.52 KiB (0.28%)
common: 524 Bytes (0.01%)

metamaskbot · 2025-02-25T21:41:52Z

Builds ready [254faaf]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1703 ± 86 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	403	2083	1629	334	160
		domContentLoaded	1383	2051	1670	173	83
		load	1436	2140	1703	178	86
		domInteractive	25	87	40	18	9
		backgroundConnect	11	84	34	23	11
		firstReactRender	14	70	31	21	10
		getState	4	68	16	19	9
		initialActions	0	0	0	0	0
		loadScripts	980	1503	1232	144	69
		setupStore	7	61	17	17	8
		uiStartup	1670	2380	1944	182	88

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 21.35 KiB (0.28%)
common: 570 Bytes (0.01%)

shared/modules/bridge-utils/bridge.util.ts

metamaskbot · 2025-02-25T23:00:21Z

Builds ready [8f14c8b]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1878 ± 101 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	246	2552	1737	537	258
		domContentLoaded	1521	2494	1846	211	101
		load	1543	2512	1878	211	101
		domInteractive	28	85	43	16	8
		backgroundConnect	13	64	39	18	9
		firstReactRender	14	74	34	21	10
		getState	6	63	22	17	8
		initialActions	0	1	0	0	0
		loadScripts	1074	2007	1381	191	92
		setupStore	8	72	23	21	10
		uiStartup	1790	2809	2152	232	111

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 21.35 KiB (0.28%)
common: 570 Bytes (0.01%)

metamaskbot · 2025-02-25T23:42:53Z

Builds ready [c3e2586]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1737 ± 55 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	498	2018	1677	292	140
		domContentLoaded	1513	2010	1704	118	57
		load	1570	2016	1737	114	55
		domInteractive	29	213	54	42	20
		backgroundConnect	11	71	36	22	10
		firstReactRender	14	78	52	26	12
		getState	5	46	9	9	4
		initialActions	0	1	0	0	0
		loadScripts	1114	1535	1261	97	46
		setupStore	7	61	12	11	5
		uiStartup	1768	2218	1986	119	57

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 21.35 KiB (0.28%)
common: 524 Bytes (0.01%)

metamaskbot · 2025-02-26T01:57:10Z

Builds ready [d033ac4]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1731 ± 72 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	273	1958	1645	340	163
		domContentLoaded	1503	2013	1698	144	69
		load	1522	2068	1731	150	72
		domInteractive	25	141	45	31	15
		backgroundConnect	11	62	32	18	9
		firstReactRender	14	70	28	19	9
		getState	5	68	13	16	8
		initialActions	0	1	0	0	0
		loadScripts	1093	1482	1272	121	58
		setupStore	8	72	20	21	10
		uiStartup	1754	2352	1988	172	83

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 21.35 KiB (0.28%)
common: 524 Bytes (0.01%)

metamaskbot · 2025-02-26T17:32:12Z

Builds ready [7bf25f7]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1725 ± 50 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	259	1994	1654	337	162
		domContentLoaded	1549	1958	1693	97	47
		load	1559	1998	1725	105	50
		domInteractive	22	99	38	17	8
		backgroundConnect	9	71	31	20	10
		firstReactRender	14	75	36	23	11
		getState	4	63	16	18	8
		initialActions	0	1	0	0	0
		loadScripts	1124	1452	1265	79	38
		setupStore	8	61	17	17	8
		uiStartup	1809	2173	1977	112	54

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 21.35 KiB (0.28%)
common: 524 Bytes (0.01%)

micaelae force-pushed the mms1867-chain-agnostic-bridge-components branch from 5c00ab7 to 37f246e Compare February 21, 2025 05:22

Base automatically changed from mms1867-chain-agnostic-bridge-components to main February 24, 2025 17:07

micaelae and others added 8 commits February 24, 2025 20:36

chore: validate solana quote.trade

9ab3921

feat: integration of account picker and v2 quote card

1c3450a

feat: new quote card again

1a080d7

feat: consistent shadow and width between quote card and account picker

e3df088

feat: subtle account picker shadow changes

8f69604

feat: better figma alignment

87e321e

fix: lint issues

ec82788

chore: destWalletAddress

cf022fb

micaelae force-pushed the mms1868-fetch-sol-quotes branch from e79d449 to cf022fb Compare February 25, 2025 04:49

micaelae changed the title ~~feat: fetch sol quotes~~ feat: fetch sol quotes + account picker and quote card Feb 25, 2025

micaelae added team-bridge team-swaps labels Feb 25, 2025

ghgoodreau added 3 commits February 25, 2025 14:16

chore: fix lint errors

b1bba5a

chore: remove unused import

c5a47b2

chore: fix tests

254faaf

ghgoodreau added 3 commits February 25, 2025 16:04

feat: add localization for en_GB

b22f7b6

fix: update prepare-bridge-page snapshot

e24947d

chore: update snapshots

8f14c8b

ghgoodreau reviewed Feb 25, 2025

View reviewed changes

shared/modules/bridge-utils/bridge.util.ts Outdated Show resolved Hide resolved

fix: revert feedata change

c3e2586

feat: selector for solana bridging enabled

d033ac4

ghgoodreau approved these changes Feb 26, 2025

View reviewed changes

ghgoodreau marked this pull request as ready for review February 26, 2025 16:19

ghgoodreau requested a review from a team as a code owner February 26, 2025 16:19

GustavoRSSilva approved these changes Feb 26, 2025

View reviewed changes

Merge branch 'main' into mms1868-fetch-sol-quotes

7bf25f7

ghgoodreau enabled auto-merge February 26, 2025 17:06

ghgoodreau added this pull request to the merge queue Feb 26, 2025

Merged via the queue into main with commit 2b91f8f Feb 26, 2025
79 checks passed

ghgoodreau deleted the mms1868-fetch-sol-quotes branch February 26, 2025 18:01

github-actions bot locked and limited conversation to collaborators Feb 26, 2025

metamaskbot added the release-12.14.0 Issue or pull request that will be included in release 12.14.0 label Feb 26, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: fetch sol quotes + account picker and quote card #30452

feat: fetch sol quotes + account picker and quote card #30452

micaelae commented Feb 19, 2025 •

edited by ghgoodreau

Loading

github-actions bot commented Feb 25, 2025

metamaskbot commented Feb 25, 2025

metamaskbot commented Feb 25, 2025

metamaskbot commented Feb 25, 2025

metamaskbot commented Feb 25, 2025

metamaskbot commented Feb 26, 2025

metamaskbot commented Feb 26, 2025

feat: fetch sol quotes + account picker and quote card #30452

feat: fetch sol quotes + account picker and quote card #30452

Conversation

micaelae commented Feb 19, 2025 • edited by ghgoodreau Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Feb 25, 2025

metamaskbot commented Feb 25, 2025

metamaskbot commented Feb 25, 2025

metamaskbot commented Feb 25, 2025

metamaskbot commented Feb 25, 2025

metamaskbot commented Feb 26, 2025

metamaskbot commented Feb 26, 2025

micaelae commented Feb 19, 2025 •

edited by ghgoodreau

Loading