feat: firefox-bundle-script #30476

itsyoboieltr · 2025-02-20T20:15:30Z

Description

Firefox submissions require the firefox reviewers to reproduce our builds. We need to make this as easy as possible for them. This PR introduces the bundle.sh script that will be updated with the environment variables from CircleCI and posted to a private repo when a release is published.

Related issues

Fixes: https://github.com/MetaMask/metamask-planning/issues/4207

Manual testing steps

Make a fake release and watch https://github.com/MetaMask/firefox-bundle-script getting updated with the correct values.

Screenshots/Recordings

Not applicable

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-02-20T20:15:45Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-02-20T20:58:50Z

Builds ready [32d78a3]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1696 ± 92 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1439	2173	1693	195	94
		domContentLoaded	1430	2096	1662	185	89
		load	1448	2179	1696	193	92
		domInteractive	19	88	43	20	10
		backgroundConnect	10	84	37	23	11
		firstReactRender	14	76	36	24	12
		getState	5	51	11	10	5
		initialActions	0	0	0	0	0
		loadScripts	996	1590	1215	152	73
		setupStore	8	64	19	20	10
		uiStartup	1642	2473	1939	229	110

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

.circleci/scripts/bundle.sh

metamaskbot · 2025-02-24T21:38:08Z

Builds ready [283eefb]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1638 ± 55 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1455	1852	1641	117	56
		domContentLoaded	1444	1795	1612	105	51
		load	1453	1850	1638	115	55
		domInteractive	25	126	41	25	12
		backgroundConnect	11	84	30	22	11
		firstReactRender	14	73	32	24	12
		getState	5	59	16	18	9
		initialActions	0	1	0	0	0
		loadScripts	1019	1383	1189	100	48
		setupStore	7	63	17	18	8
		uiStartup	1658	2087	1872	115	55

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

…ask/metamask-extension into feat/firefox-bundle-script

metamaskbot · 2025-02-25T20:25:23Z

Builds ready [2bae62b]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1658 ± 89 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	383	2291	1534	419	201
		domContentLoaded	1453	2264	1622	183	88
		load	1466	2298	1658	185	89
		domInteractive	23	78	33	13	6
		backgroundConnect	10	91	36	25	12
		firstReactRender	14	68	32	21	10
		getState	5	64	19	19	9
		initialActions	0	1	0	0	0
		loadScripts	1019	1727	1195	161	77
		setupStore	8	68	19	20	10
		uiStartup	1697	2602	1886	203	98

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

danjm

looks good to me!

.circleci/scripts/bundle.sh

.circleci/scripts/push-firefox-bundle-script.sh

metamaskbot · 2025-02-26T19:10:23Z

Builds ready [bd0e604]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1522 ± 67 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	345	1858	1453	283	136
		domContentLoaded	1362	1822	1496	129	62
		load	1384	1911	1522	139	67
		domInteractive	22	72	31	13	6
		backgroundConnect	9	85	33	22	10
		firstReactRender	13	72	34	25	12
		getState	4	54	12	14	7
		initialActions	0	1	0	0	0
		loadScripts	965	1398	1092	118	57
		setupStore	7	68	14	16	8
		uiStartup	1555	2111	1715	142	68

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-02-26T20:07:23Z

Builds ready [f729019]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1690 ± 61 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	480	2048	1632	293	141
		domContentLoaded	1473	2034	1675	125	60
		load	1486	2045	1690	127	61
		domInteractive	20	118	42	23	11
		backgroundConnect	10	33	18	6	3
		firstReactRender	14	72	41	24	11
		getState	5	57	14	17	8
		initialActions	0	0	0	0	0
		loadScripts	1074	1486	1226	99	48
		setupStore	8	69	20	20	10
		uiStartup	1628	2345	1929	153	73

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

feat: firefox-bundle-script

d97eb6e

itsyoboieltr self-assigned this Feb 20, 2025

itsyoboieltr requested a review from a team as a code owner February 20, 2025 20:15

metamaskbot added the team-extension-platform Extension Platform team label Feb 20, 2025

itsyoboieltr added 2 commits February 21, 2025 00:20

fix: remove logging

eca0a40

fix: shellcheck

32d78a3

danjm reviewed Feb 21, 2025

View reviewed changes

.circleci/scripts/bundle.sh Outdated Show resolved Hide resolved

Merge branch 'main' into feat/firefox-bundle-script

283eefb

itsyoboieltr added 19 commits February 25, 2025 01:42

Update bundle.sh

bb3cade

Merge branch 'feat/firefox-bundle-script' of https://github.com/MetaM…

2cc4f5a

…ask/metamask-extension into feat/firefox-bundle-script

test

25e311c

v1.0.0

9f072f0

v1.0.0

eb48bd1

v1.0.0

4d50525

v1.0.0

54feb4c

v1.0.0

ffeebc6

v1.0.0

e511611

v1.0.0

3ef45b8

v1.0.0

11e663b

v1.0.0

5324ce1

v1.0.0

92272ec

v1.0.0

c73e7cf

v1.0.1

9d57fb4

v1.0.1

8cd5d1a

v1.0.2

ad217eb

Update config.yml

af7f747

Update config.yml

2bae62b

itsyoboieltr requested review from danjm, davidmurdoch and Gudahtt February 25, 2025 19:54

itsyoboieltr enabled auto-merge February 26, 2025 05:21

danjm previously approved these changes Feb 26, 2025

View reviewed changes