Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: test use of scopes in listMultichainAccounts #30551

Closed
wants to merge 2 commits into from

Conversation

ccharly
Copy link
Contributor

@ccharly ccharly commented Feb 25, 2025

Description

Testing:

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

N/A

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@ccharly ccharly added DO-NOT-MERGE Pull requests that should not be merged team-accounts labels Feb 25, 2025
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Feb 25, 2025

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected] None 0 133 kB metamaskbot
npm/@metamask/[email protected] environment +1 1.37 MB metamaskbot

View full report↗︎

Have feedback? Participate in our User Experience Survey 📊

@ccharly ccharly force-pushed the test/accounts-controller-scopes branch from 77d1149 to f2c8f65 Compare February 26, 2025 09:46
ccharly added a commit to MetaMask/core that referenced this pull request Feb 26, 2025
…nAccounts` (#5388)

## Explanation

Now that accounts have their own `scopes` we should use those while
filtering (rather than relying on the account's type).

## References

Requires:
- [x] #5387

Testing PR:
- MetaMask/metamask-extension#30551 (CI is 🟢)

## Changelog

### `@metamask/account-controller`

- **CHANGED**: Use `account.scopes` in `listMultichainAccounts`

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've highlighted breaking changes using the "BREAKING" category
above as appropriate
- [x] I've prepared draft pull requests for clients and consumer
packages to resolve any breaking changes
@metamaskbot
Copy link
Collaborator

Builds ready [f2c8f65]
Page Load Metrics (1900 ± 89 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16482478189518388
domContentLoaded16352467185818388
load16492485190018689
domInteractive27152522914
backgroundConnect14115453215
firstReactRender156735199
getState65921178
initialActions01000
loadScripts11511863140814771
setupStore85716157
uiStartup185127432141209100
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -83 Bytes (-0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 907 Bytes (0.01%)

@ccharly
Copy link
Contributor Author

ccharly commented Feb 27, 2025

Testing has been valdated, now moving to the real changes:

@ccharly ccharly closed this Feb 27, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
DO-NOT-MERGE Pull requests that should not be merged team-accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants