fix: Tweak threshold on coin-overview flask build #30585

gambinish · 2025-02-26T17:18:15Z

Description

Zero balances were showing incorrectly due to a misconfigured lower threshold.

Related issues

Fixes:

Manual testing steps

Create a new flask account (not an imported SRP)
Balance should be $0.00 or 0 SOL

Screenshots/Recordings

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-02-26T17:18:26Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-02-26T17:52:59Z

Builds ready [b66bd79]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1826 ± 76 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1511	2113	1832	157	75
		domContentLoaded	1498	2097	1797	149	72
		load	1512	2115	1826	159	76
		domInteractive	27	103	47	23	11
		backgroundConnect	12	85	31	22	11
		firstReactRender	16	72	38	22	11
		getState	5	73	16	18	8
		initialActions	0	1	0	0	0
		loadScripts	1108	1629	1353	126	61
		setupStore	7	73	30	24	12
		uiStartup	1767	2404	2096	172	83

Bundle size diffs

background: 0 Bytes (0.00%)
ui: -5 Bytes (-0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-02-26T18:41:16Z

Builds ready [2245e96]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1518 ± 62 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1342	1798	1520	132	64
		domContentLoaded	1332	1764	1497	127	61
		load	1342	1786	1518	130	62
		domInteractive	24	96	41	21	10
		backgroundConnect	11	51	21	13	6
		firstReactRender	14	71	32	22	11
		getState	4	46	10	12	6
		initialActions	0	1	0	0	0
		loadScripts	962	1300	1103	101	48
		setupStore	6	57	14	14	7
		uiStartup	1495	2040	1729	140	67

Bundle size diffs

background: 0 Bytes (0.00%)
ui: -5 Bytes (-0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-02-26T19:59:19Z

Builds ready [f3e9aef]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1728 ± 54 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	536	1988	1668	282	136
		domContentLoaded	1505	1894	1702	102	49
		load	1515	2008	1728	113	54
		domInteractive	26	143	41	26	12
		backgroundConnect	11	107	32	25	12
		firstReactRender	14	69	31	21	10
		getState	5	52	12	12	6
		initialActions	0	0	0	0	0
		loadScripts	1107	1453	1287	94	45
		setupStore	7	71	24	24	11
		uiStartup	1683	2517	1975	164	79

Bundle size diffs

background: 0 Bytes (0.00%)
ui: -5 Bytes (-0.00%)
common: 0 Bytes (0.00%)

…ossibly an empty string

…amask-extension into fix/coin-overview-threshold

metamaskbot · 2025-02-26T20:47:29Z

Builds ready [a9e6d00]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1890 ± 96 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	542	2463	1836	355	170
		domContentLoaded	1608	2441	1843	202	97
		load	1647	2461	1890	200	96
		domInteractive	29	176	53	41	20
		backgroundConnect	11	97	47	29	14
		firstReactRender	16	71	34	19	9
		getState	6	87	29	23	11
		initialActions	0	1	0	0	0
		loadScripts	1194	2015	1395	184	88
		setupStore	9	55	16	12	6
		uiStartup	1901	2748	2209	236	113

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 170 Bytes (0.00%)
common: 0 Bytes (0.00%)

… zeroes

…amask-extension into fix/coin-overview-threshold

metamaskbot · 2025-02-27T00:12:00Z

Builds ready [0348781]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1718 ± 108 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	425	2010	1548	391	188
		domContentLoaded	1453	2215	1690	230	111
		load	1496	2223	1718	225	108
		domInteractive	24	77	40	17	8
		backgroundConnect	9	78	32	19	9
		firstReactRender	14	91	28	22	10
		getState	4	56	15	14	7
		initialActions	0	1	0	0	0
		loadScripts	1060	1658	1270	186	89
		setupStore	8	60	19	18	9
		uiStartup	1695	2605	1967	283	136

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 134 Bytes (0.00%)
common: 0 Bytes (0.00%)

fix: Tweak threshold on coin-overview flask build

b66bd79

metamaskbot added the team-assets label Feb 26, 2025

gambinish and others added 2 commits February 26, 2025 10:06

fix: Change threshold in aggregated balance

ea0defc

Merge branch 'main' into fix/coin-overview-threshold

2245e96

javiergarciavera previously approved these changes Feb 26, 2025

View reviewed changes

Merge branch 'main' into fix/coin-overview-threshold

f3e9aef

gambinish added 2 commits February 26, 2025 12:12

fix: Use network ticker instead of computed balance unit, since its p…

7b6e84d

…ossibly an empty string

Merge branch 'fix/coin-overview-threshold' of github.com:MetaMask/met…

a9e6d00

…amask-extension into fix/coin-overview-threshold

gambinish dismissed javiergarciavera’s stale review via a9e6d00 February 26, 2025 20:13

gambinish requested a review from javiergarciavera February 26, 2025 20:16

gambinish marked this pull request as ready for review February 26, 2025 20:16

javiergarciavera previously approved these changes Feb 26, 2025

View reviewed changes

Prithpal-Sooriya previously approved these changes Feb 26, 2025

View reviewed changes

gambinish added this pull request to the merge queue Feb 26, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 26, 2025

gambinish and others added 3 commits February 26, 2025 15:10

Merge branch 'main' into fix/coin-overview-threshold

e9678f2

fix: Use IntlNumberFormat library in favor of regex to strip trailing…

f46e85b

… zeroes

Merge branch 'fix/coin-overview-threshold' of github.com:MetaMask/met…

0348781

…amask-extension into fix/coin-overview-threshold

gambinish dismissed stale reviews from Prithpal-Sooriya and javiergarciavera via 0348781 February 26, 2025 23:38

gambinish requested review from Prithpal-Sooriya and javiergarciavera February 27, 2025 01:10

zone-live approved these changes Feb 27, 2025

View reviewed changes

aganglada approved these changes Feb 27, 2025

View reviewed changes

zone-live added this pull request to the merge queue Feb 27, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 27, 2025

zone-live added this pull request to the merge queue Feb 27, 2025

Merged via the queue into main with commit 5abb061 Feb 27, 2025
79 checks passed

zone-live deleted the fix/coin-overview-threshold branch February 27, 2025 12:40

github-actions bot locked and limited conversation to collaborators Feb 27, 2025

metamaskbot added the release-12.14.0 Issue or pull request that will be included in release 12.14.0 label Feb 27, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Tweak threshold on coin-overview flask build #30585

fix: Tweak threshold on coin-overview flask build #30585

gambinish commented Feb 26, 2025 •

edited

Loading

github-actions bot commented Feb 26, 2025

metamaskbot commented Feb 26, 2025

metamaskbot commented Feb 26, 2025

metamaskbot commented Feb 26, 2025

metamaskbot commented Feb 26, 2025

metamaskbot commented Feb 27, 2025

fix: Tweak threshold on coin-overview flask build #30585

fix: Tweak threshold on coin-overview flask build #30585

Conversation

gambinish commented Feb 26, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Feb 26, 2025

metamaskbot commented Feb 26, 2025

metamaskbot commented Feb 26, 2025

metamaskbot commented Feb 26, 2025

metamaskbot commented Feb 26, 2025

metamaskbot commented Feb 27, 2025

gambinish commented Feb 26, 2025 •

edited

Loading