Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore (cherry-pick): cp-12.13.0 remove SRP video (#30586) #30590

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Feb 26, 2025

Cherry pick e957fed to v12.13.0

Description

Removed the SRP video during wallet creation flow and replaced it with a SRP lock design

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Freshly installed app
  2. Create wallet
  3. Create password
  4. During the wallet phrase flow you should see no video and a new design

Screenshots/Recordings

NA

Before

Screenshot 2025-02-26 at 10 23 07 AM

After

Screenshot 2025-02-26 at 10 23 37 AM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

## **Description**

Removed the SRP video during wallet creation flow and replaced it with a
SRP lock design

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30586?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Freshly installed app
2. Create wallet
3. Create password
4. During the wallet phrase flow you should see no video and a new
design

## **Screenshots/Recordings**

NA

### **Before**

<img width="1840" alt="Screenshot 2025-02-26 at 10 23 07 AM"
src="https://github.com/user-attachments/assets/8ddcfd34-0fe4-4b53-afaf-04dab0639876"
/>

### **After**

<img width="1840" alt="Screenshot 2025-02-26 at 10 23 37 AM"
src="https://github.com/user-attachments/assets/3db6ea6b-4bbd-4be4-9951-ce12a35e4284"
/>

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@danjm danjm requested a review from a team as a code owner February 26, 2025 21:05
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-extension-platform Extension Platform team label Feb 26, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [7fab388]
Page Load Metrics (1585 ± 36 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint27716911517294141
domContentLoaded1413167715657235
load1424169315857536
domInteractive227835167
backgroundConnect95622157
firstReactRender1470322311
getState413721
initialActions01000
loadScripts1006126011376431
setupStore880252512
uiStartup16332436186217986

@danjm danjm merged commit c85f971 into Version-v12.13.0 Feb 27, 2025
70 checks passed
@danjm danjm deleted the cherry-pick-e957fed branch February 27, 2025 00:45
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2025
@metamaskbot metamaskbot added the release-12.13.0 Issue or pull request that will be included in release 12.13.0 label Feb 27, 2025
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-12.13.0 on PR, as PR was cherry-picked in branch 12.13.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.13.0 Issue or pull request that will be included in release 12.13.0 team-extension-platform Extension Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants