Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cp-12.13.0 replace 3D flask mascot with 2D version #30592

Merged
merged 4 commits into from
Feb 27, 2025

Conversation

vinnyhoward
Copy link
Contributor

@vinnyhoward vinnyhoward commented Feb 26, 2025

Description

Issue: The new Flask 3D asset isn't fully supported

Solution: Replace all instances of the 3D asset for Flask with the 2D counterpart temporarily until we fix the issue

Open in GitHub Codespaces

Related issues

Fixes: #30338

Manual testing steps

  1. Run yarn start:flask
  2. Confirm that the 2D flask logo is visible in the following flows
  3. Swap Quote flow
  4. Create Wallet flow
  5. Login

Screenshots/Recordings

ui/pages/onboarding-flow/welcome/welcome.js

Before After
before_welcome after_welcome

ui/pages/swaps/awaiting-swap/awaiting-swap.js

Before After
before_await_swap after_await_swap

ui/pages/swaps/loading-swaps-quotes/loading-swaps-quotes.js

Before After
before_loading_swap_quote after_loading_swap_quote

ui/pages/swaps/mascot-background-animation/mascot-background-animation.js

Before After
before_background_animation after_background_animation

ui/pages/unlock-page/unlock-page.component.js

Before After
before after

Before

NA

After

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [x ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vinnyhoward vinnyhoward requested review from a team as code owners February 26, 2025 21:34
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vinnyhoward vinnyhoward changed the title fix(30338): replace 3D flask mascot with 2D version fix: cp-12.13.0 replace 3D flask mascot with 2D version Feb 26, 2025
@vinnyhoward vinnyhoward added team-swaps release-12.13.0 Issue or pull request that will be included in release 12.13.0 labels Feb 26, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [af5ce86]
Page Load Metrics (1824 ± 58 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint36920591746338162
domContentLoaded15462045178311857
load15992059182412058
domInteractive26133573617
backgroundConnect1371412210
firstReactRender166632199
getState56220199
initialActions00000
loadScripts11351508133010450
setupStore7131011
uiStartup18342332206911455
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 49 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@vinnyhoward vinnyhoward added this pull request to the merge queue Feb 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 27, 2025
@vinnyhoward vinnyhoward added this pull request to the merge queue Feb 27, 2025
Merged via the queue into main with commit c186fb0 Feb 27, 2025
81 checks passed
@vinnyhoward vinnyhoward deleted the fix-30338-temp-flask-3D branch February 27, 2025 00:49
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2025
@metamaskbot metamaskbot added the release-12.14.0 Issue or pull request that will be included in release 12.14.0 label Feb 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.13.0 Issue or pull request that will be included in release 12.13.0 release-12.14.0 Issue or pull request that will be included in release 12.14.0 team-swaps team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Documenting the branding related observations
4 participants