Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix lint warnings output by yarn lint:fix #13400

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Conversation

OGPoyraz
Copy link
Member

@OGPoyraz OGPoyraz commented Feb 7, 2025

Description

This PR aims to fix warnings output by yarn lint:fix

Related issues

N/A

Manual testing steps

N/A

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz added the No E2E Smoke Needed If the PR does not need E2E smoke test run label Feb 7, 2025
@OGPoyraz OGPoyraz requested review from a team as code owners February 7, 2025 09:01
@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Feb 7, 2025
Copy link

sonarqubecloud bot commented Feb 7, 2025

Copy link
Contributor

@Prithpal-Sooriya Prithpal-Sooriya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for notifications

@OGPoyraz OGPoyraz added Run Smoke E2E Triggers smoke e2e on Bitrise and removed No E2E Smoke Needed If the PR does not need E2E smoke test run labels Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b7e80a4
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/61216f2e-622e-4c36-ab13-d8a6abc8a694

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@OGPoyraz OGPoyraz enabled auto-merge February 7, 2025 13:31
@OGPoyraz OGPoyraz added this pull request to the merge queue Feb 11, 2025
Merged via the queue into main with commit d5876f6 Feb 11, 2025
48 of 52 checks passed
@OGPoyraz OGPoyraz deleted the chore/fix-lint-issues branch February 11, 2025 10:36
@github-actions github-actions bot locked and limited conversation to collaborators Feb 11, 2025
@metamaskbot metamaskbot added the release-7.41.0 Issue or pull request that will be included in release 7.41.0 label Feb 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.41.0 Issue or pull request that will be included in release 7.41.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants