Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix duplicate native entry after send flow #13413

Merged
merged 4 commits into from
Feb 12, 2025

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Feb 10, 2025

Description

Related issues

Fixes: #13409

Manual testing steps

  1. Choose BNB or AVAX network
  2. process send of native token
  3. check if there's no duplicated asset entry

Screenshots/Recordings

Before

After

Screen.Recording.2025-02-10.at.21.01.19.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb force-pushed the fix/fix-duplicate-entry-send branch from 85e1bc6 to 07f1e43 Compare February 10, 2025 19:36
@salimtb salimtb added the Run Smoke E2E Triggers smoke e2e on Bitrise label Feb 10, 2025
Copy link
Contributor

github-actions bot commented Feb 10, 2025

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 07f1e43
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/38640458-cb96-4493-a871-ec35e3d86009

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 10, 2025
@salimtb salimtb marked this pull request as ready for review February 11, 2025 09:57
@salimtb salimtb requested a review from a team as a code owner February 11, 2025 09:57
@Prithpal-Sooriya Prithpal-Sooriya added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 11, 2025
@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 11, 2025
Copy link
Contributor

github-actions bot commented Feb 11, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a284e68
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/93f2adbd-188b-4ef6-ad0b-e9166a73f874

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 11, 2025
Copy link
Contributor

github-actions bot commented Feb 11, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 39285f1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1ad40a12-3b4d-4278-9420-822575a8d8de

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 11, 2025
@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 11, 2025
Copy link
Contributor

github-actions bot commented Feb 11, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b96fbf5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0fcc67d7-4b18-40cd-8c8a-95dd4d9d095b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 11, 2025
@salimtb salimtb added this pull request to the merge queue Feb 12, 2025
Merged via the queue into main with commit 1885e2a Feb 12, 2025
51 checks passed
@salimtb salimtb deleted the fix/fix-duplicate-entry-send branch February 12, 2025 00:15
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2025
@metamaskbot metamaskbot added the release-7.41.0 Issue or pull request that will be included in release 7.41.0 label Feb 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.41.0 Issue or pull request that will be included in release 7.41.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
Archived in project
3 participants