Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: activate sourcemap support in all packages and resolve issues #730

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

omridan159
Copy link
Contributor

@omridan159 omridan159 commented Mar 5, 2024

Explanation

Activate sourcemap support in all packages and resolve issues

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@omridan159 omridan159 requested a review from a team as a code owner March 5, 2024 12:41
Copy link
Collaborator

@christopherferreira9 christopherferreira9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 87.8 kB adrai

🚮 Removed packages: npm/@rollup/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.40%. Comparing base (4ecc000) to head (9b32b6a).

Files Patch % Lines
packages/sdk/src/sdk.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #730      +/-   ##
==========================================
- Coverage   81.49%   81.40%   -0.09%     
==========================================
  Files         173      173              
  Lines        3447     3447              
  Branches      805      806       +1     
==========================================
- Hits         2809     2806       -3     
- Misses        638      641       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@christopherferreira9 christopherferreira9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@omridan159 omridan159 merged commit 1245d24 into main Mar 5, 2024
32 checks passed
@omridan159 omridan159 deleted the feat_enable-sourcemaps branch March 5, 2024 14:11
@omridan159 omridan159 mentioned this pull request Mar 5, 2024
@abretonc7s abretonc7s mentioned this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants