Build iframe execution environment with Webpack #1977
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: [email protected] |
naugtur
reviewed
Nov 21, 2023
| @@ -1,7 +1,12 @@ | |||
| // eslint-disable-next-line import/no-unassigned-import | |||
| import 'ses'; | |||
There was a problem hiding this comment.
this should not be imported into the bundle after we add the webpack plugin.
There was a problem hiding this comment.
Indeed it should not, we should use the LM Compartment
There was a problem hiding this comment.
Yeah, I added it temporarily so that the execution environment works. Without it, Compartment would be undefined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be built with
yarn build:webpackinpackages/snaps-execution-environments.