Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intel SKLearn Optimization Doc Update for 10/18 webinar #115443

Closed
wants to merge 4 commits into from

Conversation

raoberman
Copy link
Contributor

Adding SKLearnEx sections to existing AzureML documentation so users know how to use SKLearnEx in AzureML before 10/18 Intel+AzureML Webinar

Referenced notebook changes related to PR and already merged: Azure/azureml-examples#2429

@raoberman
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Intel Corporation"

@prmerger-automator
Copy link
Contributor

@raoberman : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 36f1051:

✅ Validation status: passed

File Status Preview URL Details
articles/machine-learning/how-to-train-scikit-learn.md ✅Succeeded
articles/machine-learning/tutorial-azure-ml-in-a-day.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Court72
Copy link
Contributor

Court72 commented Oct 2, 2023

@sdgilley
@balapv

Can you review the proposed changes?

When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Oct 2, 2023
@balapv
Copy link
Contributor

balapv commented Oct 2, 2023

#sign-off

@Jak-MS
Copy link
Contributor

Jak-MS commented Oct 2, 2023

@sdgilley - still need your approval/sign off before this can be moved forward.

Also, NOTE - @raoberman - that this PR adds Jupyter notebook calls and because of that, the commits will need to be moved into the private repo for staging before they can be merged. @balapv @sdgilley - can you do this?

let us know if you'd like our assistance.
#hold-off

@sdgilley
Copy link
Contributor

sdgilley commented Oct 3, 2023

The notebook changes have not been merged - Azure/azureml-examples#2429 has some build errors that you'll need to resolve first. Can you coordinate with @balapv to get these fixed and merged?

@raoberman
Copy link
Contributor Author

@sdgilley @balapv the changes were merged in a different PR, and the tags are in the notebook metadata. not sure why they're not being detected.
Correct PR: Azure/azureml-examples#2692
https://github.com/Azure/azureml-examples/blob/main/sdk/python/jobs/single-step/scikit-learn/train-hyperparameter-tune-deploy-with-sklearn/train-hyperparameter-tune-with-sklearn.ipynb

@sdgilley
Copy link
Contributor

sdgilley commented Oct 3, 2023

These changes were merged into the private repo.
#please-close.

@sdgilley
Copy link
Contributor

sdgilley commented Oct 4, 2023

@raoberman - I merged your changes in a separate PR. But am reversing the change to the quickstart this morning. The quickstart uses a curated environment, which does not include the required package. The purpose of the quickstart is to get the basics up and running as quickly as possible; it's not the right place to introduce custom environments. So, we can leave your change in the how-to article, but not in the quickstart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants