Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added F1 keywords #5152

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Added F1 keywords #5152

merged 1 commit into from
Jan 17, 2025

Conversation

Omotola
Copy link
Contributor

@Omotola Omotola commented Jan 16, 2025

Added F1 keywords to a couple cpp ide docs so when customers click the help button it takes them to the right page instead of the fallback error page.

Copy link
Contributor

@Omotola : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 264ec5a:

✅ Validation status: passed

File Status Preview URL Details
docs/ide/refactoring/change-signature.md ✅Succeeded
docs/ide/refactoring/extract-function.md ✅Succeeded
docs/ide/refactoring/rename.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@v-dirichards
Copy link
Contributor

Hi @Omotola - it looks like you have access to the private repo, and if so - you should use that for content updates.

I'll leave this open in case @TylerMSFT wants to review it, but in the future you should submit changes to the private repo: cpp-docs-pr.


@TylerMSFT

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Jan 16, 2025
@@ -2,6 +2,7 @@
description: "Learn more about: Change Signature"
title: "Change Signature"
ms.date: "09/18/2022"
f1_keywords: ["vc.pkg.refactoring.changesignaturedlg"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm less familiar with this area. Can you help me understand why these keywords are prefaced with VC Package?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Tyler, The keywords are to map what we have on the backend to a page in the docs. I'm not 100% sure how the naming convention is decided but in this case they are related to the location of the feature within the source code. The vc.pkg part is probably from the name of the compiled binary vcpkg.dll.

@TylerMSFT
Copy link
Collaborator

#sign-off

@ttorble ttorble merged commit e081295 into MicrosoftDocs:main Jan 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants