Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganizing the code sample and include final solution for the module: 'Work with files and directories in a Node.js app' #60

Merged

Conversation

glaucia86
Copy link
Member

@glaucia86 glaucia86 commented Jan 22, 2024

This PR is related with the module: Work with files and directories in a Node.js app

@glaucia86
Copy link
Member Author

@diberry I made some significant changes. I would like to hear about if it's fine or should we make different ;)

Because if everything is fine, according to this pull request, I will make mini pull requests because this lesson contains many examples, to avoid a large pull request.

Copy link
Contributor

@diberry diberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these have test in place and the tests are called from GitHub workflow?

@glaucia86
Copy link
Member Author

Do these have test in place and the tests are called from GitHub workflow?

I'll include these changes in the GH workflow

@glaucia86 glaucia86 marked this pull request as ready for review January 23, 2024 19:25
@glaucia86 glaucia86 self-assigned this Jan 23, 2024
@glaucia86 glaucia86 merged commit 1b6c46c into MicrosoftDocs:main Jan 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants