-
Notifications
You must be signed in to change notification settings - Fork 226
Conversation
Awesome! ✨ |
this.colorizeAddress = address => { | ||
let HTML = ''; | ||
// Parse URL using an <a> element | ||
let a = document.createElement('a'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For URL parsing you can use the Windows.Foundation.Uri WinRT API.
We have the URI
const set here and you can see a usage example here.
Instead of displaying the full |
Got rid of |
Great stuff! Regarding the copy event, have you looked into using the Clipboard.ContentChanged WinRT API? |
@jayrenn Hooking into a central event tracking all clipboard changes would not be ideal in my opinion since it'd be hard to know when the copied content actually comes from the address bar or just some content being copied from the page. The best would be if there was a way to copy arbitrary text content, then I could hook into the |
The |
Intercepting an event is not an issue, putting any kind of custom text data on the clipboard itself is. Doesn't matter if I caught |
Hi @DJDavid98! Sorry for the delay. Can you resubmit the PR? |
Thank you! |
No problem, I understand that this could've caused legal issues before and that's probably the reason for the delay. |
This completes the following points of #6:
http:
protocol from address barNewly added JavaScript code is well-commented, address part colors are specified in
browser.css